qt: Change uninstall icon on Windows #16760

GChuf commented at 6:50 PM on August 29, 2019: contributor

Change uninstall icon in Windows by changing a registry value. Original uninstall.exe icon remains the same Reason: almost no other modern program uses that uninstall icon in Windows.

before: before after: after

jonasschnelli approved

jonasschnelli commented at 6:55 PM on August 29, 2019: contributor

utACK 635e9154da223ca760713d7b3b66c0a9321d1277

GChuf commented at 7:01 PM on August 29, 2019: contributor

As I said, the original uninstall icon remains the same. Not sure if we should change that as well - maybe with bitcoin logo all in black?

Screenshot_84

DrahtBot added the label Build system on Aug 29, 2019

[qt] Change uninstall icon on Windows 635e9154da

fanquake renamed this:
~~[qt] Change uninstall icon on Windows~~
qt: Change uninstall icon on Windows
on Aug 29, 2019

fanquake added the label Windows on Aug 30, 2019

fanquake requested review from NicolasDorier on Aug 30, 2019

GChuf commented at 10:36 AM on August 30, 2019: contributor

I decided to add a black icon, sizes 64px - 16px, RGBA and RGB. Reason: might also come in handy in the future for something else, and the uninstall icon display will not be dependent on registry values.

about

promag commented at 11:23 AM on August 30, 2019: member

Actually I think you could revert to 635e9154da223ca760713d7b3b66c0a9321d1277, it just fixes the icon. Let's discuss the black icon elsewhere?

ACK 635e9154da223ca760713d7b3b66c0a9321d1277.

in share/setup.nsi.in:24 in 7aada05431 outdated

  20 | @@ -21,7 +21,7 @@ SetCompressor /SOLID lzma
  21 |  !define MUI_STARTMENUPAGE_DEFAULTFOLDER "@PACKAGE_NAME@"
  22 |  !define MUI_FINISHPAGE_RUN "$WINDIR\explorer.exe"
  23 |  !define MUI_FINISHPAGE_RUN_PARAMETERS $INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@
  24 | -!define MUI_UNICON "${NSISDIR}\Contrib\Graphics\Icons\modern-uninstall.ico"
  25 | +!define MUI_UNICON "@abs_top_srcdir@/share/pixmaps/bitcoin-black.ico"

NicolasDorier commented at 1:08 PM on August 30, 2019:

should be \ not /

GChuf commented at 2:39 PM on August 30, 2019:

I don't think so. It was backslashes because that was NSIS directory which I think only appears when installing on Windows. The pixmaps/icons are in the source folder. Take a look at how bitcoin-qt.exe icon is defined: !define MUI_ICON "@abs_top_srcdir@/share/pixmaps/bitcoin.ico"