build: remove WINDOWS_BITS from build system #17756

fanquake commented at 6:14 PM on December 16, 2019: member

We no longer build/ship 32 bit windows executables.

build: remove WINDOWS_BITS from build system

We no longer build/ship 32 bit windows executables.

abc147de95

fanquake added the label Windows on Dec 16, 2019

fanquake added the label Build system on Dec 16, 2019

fanquake added the label Needs gitian build on Dec 16, 2019

practicalswift commented at 10:34 PM on December 16, 2019: contributor

Concept ACK

Nice to see 32 bit go

DrahtBot commented at 8:54 AM on December 17, 2019: member

Gitian builds

File	commit 988eaf2fcb71284c5fc57c7ef755bdafa4b929a0<br>(master)	commit 3dbf934c9d6488d95d66425893cad7f497ec0149<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`b6dc0c5d51830318...`	`f987b14154d42402...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`15834d165df997c5...`	`9a87961440568b18...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`7c0754cfbc7e7198...`	`0dbe470056484ece...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`203e4e5797f28a62...`	`934166c33de89b9d...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`6edb2b77648bc680...`	`dad2ba4fd5cddce7...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`d3f7ad6d95146b78...`	`6ff0b23dffd6680c...`
bitcoin-0.19.99-osx-unsigned.dmg	`beed930ff9edca71...`	`66521dcf158309be...`
bitcoin-0.19.99-osx64.tar.gz	`cf44556c93cbd5c0...`	`a365936f258709ac...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`af9e7357f1eb6df9...`	`8185c684a3b3c484...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`3783c833c4c77bbb...`	`a4f66c65608ceaf8...`
bitcoin-0.19.99-win64-debug.zip	`56b17250c24caea2...`	`513a0e9ecdd2dafd...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`2226867080b28abc...`	`8cfcbf0fa870c6a7...`
bitcoin-0.19.99-win64.zip	`1e70d2cc11bd6c5a...`	`0f64ac63ee566fd3...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`200807491502418e...`	`b3ddde8c3cd9fbdd...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`48a1543b61af49cf...`	`fc3f42f74c41ad45...`
bitcoin-0.19.99.tar.gz	`870d5c1ce7791ad4...`	`189f87708bec20f6...`
bitcoin-core-linux-0.20-res.yml	`827b8a6ad28992d8...`	`523531829a7d1226...`
bitcoin-core-osx-0.20-res.yml	`6a8524ba61f92707...`	`7d2227fa85d0525e...`
bitcoin-core-win-0.20-res.yml	`24ad4330a8ab1777...`	`fb6b8a3fbfe779ad...`
linux-build.log	`72b7e51c1a335b60...`	`ca0ecbbb74963eef...`
osx-build.log	`a38916c18320ab3a...`	`30eb61b47b19679c...`
win-build.log	`0a000a5b8bf1fd61...`	`615954447c49145b...`
bitcoin-core-linux-0.20-res.yml.diff		`e79a2bf72ad7fd8d...`
bitcoin-core-osx-0.20-res.yml.diff		`d7775b8ace6de351...`
bitcoin-core-win-0.20-res.yml.diff		`19f01be48bb3f2b7...`
linux-build.log.diff		`506945c5a43cee42...`
osx-build.log.diff		`4794441658e10e55...`
win-build.log.diff		`365db1cb10ab5782...`

DrahtBot removed the label Needs gitian build on Dec 17, 2019

laanwj commented at 9:13 AM on December 17, 2019: member

LGTM ACK abc147de95fb294a2c0a3105695e708517010322

In the longer run I think it makes sense to stop mentioning "64 bits" at all in user visible places, but this is the obvious change for now—wouldn't want to mess up things with registry keys and start menu entries.

fanquake referenced this in commit ab4e6ad762 on Dec 17, 2019

fanquake merged this on Dec 17, 2019

fanquake closed this on Dec 17, 2019

fanquake deleted the branch on Dec 17, 2019

fanquake commented at 5:17 PM on December 17, 2019: member

In the longer run I think it makes sense to stop mentioning "64 bits" at all in user visible places, but this is the obvious change for now—wouldn't want to mess up things with registry keys and start menu entries.

I agree. I kept this to the smallest possible, non-controversial change.

sidhujag referenced this in commit 3b271a293e on Dec 17, 2019

MarkLTZ referenced this in commit 1d480f0b58 on Dec 18, 2019

luke-jr referenced this in commit 96315d9a36 on Jun 9, 2020

sidhujag referenced this in commit b792ada463 on Nov 10, 2020

luke-jr referenced this in commit d519b13ee6 on Nov 17, 2020

luke-jr referenced this in commit 6091aebe8a on Nov 25, 2020

zkbot referenced this in commit 372f695d4d on Jun 5, 2021

random-zebra referenced this in commit 3614de632e on Jul 19, 2021

luke-jr referenced this in commit d96d9d9370 on Oct 6, 2021

UdjinM6 referenced this in commit 4a9e13edd2 on Oct 23, 2021

UdjinM6 referenced this in commit dc6cd0f08c on Oct 23, 2021

UdjinM6 referenced this in commit 4786fb0f71 on Dec 4, 2021

UdjinM6 referenced this in commit 632c759352 on Dec 5, 2021

MarcoFalke locked this on Dec 16, 2021