build: Drop all of the ZeroMQ patches #18405

This PR gets rid of the all patches for ZeroMQ:

• the Mingw-w64 5.0 (Ubuntu 18.04 bionic) is used to build the Windows binaries
• it is safe to use pthread_setname_np since #17538 when the minimal glibc version is set to 2.17; see: #11986 (comment)

Concept ACK.

Concept ACK: less is more

Concept ACK

+ make -j1 -C /home/ubuntu/build/bitcoin/depends HOST=x86_64-linux-gnu
make: Entering directory '/home/ubuntu/build/bitcoin/depends'
sha256sum: /home/ubuntu/build/bitcoin/depends/patches/zeromq/0001-fix-build-with-older-mingw64.patch: No such file or directory
sha256sum: /home/ubuntu/build/bitcoin/depends/patches/zeromq/0002-disable-pthread_set_name_np.patch: No such file or directory
Extracting zeromq...
/home/ubuntu/cache/common/zeromq-4.3.1.tar.gz: OK
Preprocessing zeromq...
/bin/sh: 1: cd: can't cd to /home/ubuntu/build/bitcoin/depends/patches/zeromq
cp: cannot stat '0001-fix-build-with-older-mingw64.patch': No such file or directory
/bin/sh: 1: cd: can't cd to /home/ubuntu/build/bitcoin/depends/patches/zeromq
cp: cannot stat '0002-disable-pthread_set_name_np.patch': No such file or directory
funcs.mk:251: recipe for target '/home/ubuntu/build/bitcoin/depends/work/build/x86_64-linux-gnu/zeromq/4.3.1-726059c460b/.stamp_preprocessed' failed
make: *** [/home/ubuntu/build/bitcoin/depends/work/build/x86_64-linux-gnu/zeromq/4.3.1-726059c460b/.stamp_preprocessed] Error 1
make: Leaving directory '/home/ubuntu/build/bitcoin/depends'

@MarcoFalke gitian builds were maid against 763b839fad1125320f32d69621995277aa59dd0a The current top commit is f642b49af73fedc6dc9af4ac299e4cfa80755583 Sorry.

Mind re-assigning "Needs gitian build"?

Looks like most "stable" releases of distributions have mingw-w64 > 4 as well: https://repology.org/project/mingw-w64/versions

<!--a722867cd34abeea1fadc8d60700f111-->

Gitian builds

Concept ACK, though I don't think there's any hurry to do this. I'd like to avoid going back and forth debate over this as happened with #18427.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #19761 (build: improve sed robustness by not using sed by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ACK f642b49af73fedc6dc9af4ac299e4cfa80755583.

079df9609e6ed2a09949ebe5e98a179f61709801 - This is ok. As noted most distros have a much more recent version of mingw-w64 available. Also if someone is using mingw-w64 < 4 (i.e Ubuntu 14.04), at least the failure will be obvious, as zmq in depends will fail to build:

In file included from src/windows.hpp:61:0,
                 from src/precompiled.hpp:49,
                 from src/address.cpp:30:
/usr/share/mingw-w64/include/iphlpapi.h:147:5: error: 'SOCKADDR_IN6' does not name a type
     SOCKADDR_IN6 Ipv6Address;
     ^
cc1plus: warning: unrecognized command line option "-Wno-tautological-constant-compare" [enabled by default]
cc1plus: warning: unrecognized command line option "-Wno-atomic-alignment" [enabled by default]
make[1]: *** [src/src_libzmq_la-address.lo] Error 1

However, if they are cross-compiling for Windows using 14.04, they've already got other issues to deal with. Qt doesn't build:

compiling qwindowsnativeinterface.cpp
compiling qwindowsopengltester.cpp
compiling qwin10helpers.cpp
qwin10helpers.cpp:60:37: fatal error: uiviewsettingsinterop.h: No such file or directory
 #  include <uiviewsettingsinterop.h>
                                     ^
compilation terminated.
compiling qwindowsclipboard.cpp
compiling qwindowsdrag.cpp
compiling qwindowstabletsupport.cpp
make[5]: *** [.obj/release/qwin10helpers.o] Error 1

and even if you build depends, skipping QT and zeromq, bitcoind doesn't compile, due to the inclusion of the <codecvt> header:

  CXX      libbitcoin_common_a-netbase.o
  CXX      libbitcoin_common_a-net_permissions.o
netbase.cpp:19:19: fatal error: codecvt: No such file or directory
 #include <codecvt>
                   ^
compilation terminated.
  CXX      libbitcoin_common_a-outputtype.o
  CXX      policy/libbitcoin_common_a-feerate.o
make[2]: *** [libbitcoin_common_a-netbase.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/bitcoin/src'

f642b49af73fedc6dc9af4ac299e4cfa80755583 - as mentioned, pthread_setname_np has been available since glibc 2.12. We now require 2.17+.

the Mingw-w64 5.0 (Ubuntu 18.04 bionic) is used to build the Windows binaries

I do want to mention that this by itself isn't sufficient justification for dropping patches, as the version of Ubuntu we use to build releases (which can be quite recent) isn't the only OS we have to worry about supporting.