Build: Move wallet RPCs to their own libbitcoin_walletrpcs module #18469

1. 
   luke-jr commented at 5:20 am on March 30, 2020: member

   Attempt to fix #18465. This also trims the RPC code out of the bitcoin-wallet build.

   The build currently fails for bench_bitcoin for reasons I can’t figure out.

   Also, I’m not really sure what is needed for MSVC.

   Chasing Concept ACKs for now (or ideas for alternative directions, please post to #18465 )

2. interfaces: Don't require ChainClients to implement things they don't use 6d3f16ee59
3. Build: Move wallet RPCs to their own libbitcoin_walletrpcs module bc2aed609b
4. Build: Move util/url to libbitcoin_server module 5eb7f3ed03
5. fanquake added the label Wallet on Mar 30, 2020
6. 
   DrahtBot commented at 7:57 am on March 30, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18471 (qa: Test shared validation interface by promag)
   • #18354 (Protect wallet by using shared pointers by bvbfan)
   • #18338 (Fix wallet unload race condition by promag)
   • #17999 (refactor: Add ChainClient setMockTime, getWallets methods by ryanofsky)
   • #16923 (wallet: Handle duplicate fileid exception by promag)
   • #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)
   • #16546 ([WIP] External signer support - Wallet Box edition by Sjors)
   • #16367 (Multiprocess build support by ryanofsky)
   • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   ryanofsky commented at 9:47 am on March 30, 2020: member

   I will be honest and say I don’t really understand how this PR is trying to organize the libraries and API, but I did post an alternate fix #18465 (comment) that I think addresses the problem simply and directly
8. 
   luke-jr commented at 11:38 am on March 30, 2020: member

   @ryanofsky The point here is to only link wallet RPC stuff when there is a RPC server (and therefore urlDecode)
9. luke-jr closed this on Apr 8, 2020

   ---

10. DrahtBot locked this on Feb 15, 2022

Contributors
luke-jr DrahtBot ryanofsky

Labels
Wallet