Rebrand to Bitcoin Corrr #18489

MarcoFalke commented at 3:01 AM on April 1, 2020: member

Screenshots:

Screenshot from 2020-04-01 00-03-52

Screenshot from 2020-04-01 00-04-17

Rebrand to Bitcoin Corrr 7777c40abc

luke-jr commented at 3:04 AM on April 1, 2020: member

The image is a placeholder, right? Kinda pixelated and poor quality as-is...

Concept ACK

in src/qt/splashscreen.cpp:66 in 7777c40abc outdated

  63 | @@ -64,7 +64,7 @@ SplashScreen::SplashScreen(interfaces::Node& node, Qt::WindowFlags f, const Netw
  64 |      pixPaint.fillRect(rGradient, gradient);
  65 |  
  66 |      // draw the bitcoin icon, expected size of PNG: 1024x1024

jeandudey commented at 3:32 AM on April 1, 2020:

    // draw the bitcoin corr icon, expected size of PNG: 1024x1024

practicalswift commented at 5:35 AM on April 1, 2020:

@jeandudey Please note that the suggested name is "Corrr" (three R) and not "Corr" (two R).

It might not sound important but the third R really underscores that the money printer is running at full capacity.

Somewhat related: "corr" might be misinterpreted as "correlation" and it should be noted that correlation does not imply causation. Correlation is fragile. Causation is robust (like Bitcoin Corrr).

jeandudey commented at 1:39 PM on April 1, 2020:

Sorry my mistake, this isn't a blocker for me, of course the correct "Corrr" should fixed ASAP.

Not a strong opinion though.

DrahtBot added the label Build system on Apr 1, 2020

DrahtBot added the label GUI on Apr 1, 2020

in src/qt/splashscreen.cpp:67 in 7777c40abc outdated

  63 | @@ -64,7 +64,7 @@ SplashScreen::SplashScreen(interfaces::Node& node, Qt::WindowFlags f, const Netw
  64 |      pixPaint.fillRect(rGradient, gradient);
  65 |  
  66 |      // draw the bitcoin icon, expected size of PNG: 1024x1024
  67 | -    QRect rectIcon(QPoint(-150,-122), QSize(430,430));
  68 | +    QRect rectIcon(QPoint(-15,-12), QSize(270,270));

practicalswift commented at 5:33 AM on April 1, 2020:

Nit: Please clang-format -i to get proper social distancing between -15 and -12.

Same comment also applies to 270 and 270 (self-quarantine).

Sjors commented at 3:09 PM on April 1, 2020:

And why isn't this variable called rektIcon?

practicalswift changes_requested

practicalswift commented at 5:35 AM on April 1, 2020: contributor

Concept ACK modulo nits

laanwj commented at 5:53 AM on April 1, 2020: member

Concept ACK, I think this is really going with the times which is good, but also this only makes sense if it includes a fork to give a trillion BTC in stimulus measures to us.

abrkn commented at 5:59 AM on April 1, 2020: none

The image is a placeholder, right? Kinda pixelated and poor quality as-is...

Concept ACK

I think the pixelated logo is a strong statement: "I'm in it for the technology. BRRRRRRRR"

JeremyRubin commented at 6:04 AM on April 1, 2020: contributor

Excuse me, you may not know this but while it's fine to rebrand to Bitcoin Corr, the CNetMessageType Buffer is only allowed to be 12 characters long so I'm worried we might have some network issues with the name Bitcoin Corrr as it's 13 characters. As a suggestion, maybe we can just use the name "Bitcorrrn" which is I think more clear to users about the quality of the software they are receiving.

cryptozeny approved

cryptozeny commented at 6:06 AM on April 1, 2020: none

LGTM

sidhujag commented at 6:40 AM on April 1, 2020: none

Concept ACK, bring back alert messages so we can announce this to all listening peers.

jonasschnelli commented at 6:42 AM on April 1, 2020: contributor

Nice! I waited for this... Concept ACK. Gitian Build: https://bitcoin.jonasschnelli.ch/gitian/build/66

mFarghaly commented at 7:38 AM on April 1, 2020: none

LGTM. MERRRRRRRGE.

FelixWeis commented at 7:45 AM on April 1, 2020: contributor

I always support a new logo and rebranding. Not implementing a new, completly arbitrary monetary policy change feels like a wasted oBRRRtunity. NACK!

laanwj commented at 8:08 AM on April 1, 2020: member

I think we should emphasize that bitcoin is magic internet money, so doesn't need something as trivial as a printing press, here's an alternative proposal:

bitcoin-magie

Danny-Scott commented at 8:19 AM on April 1, 2020: contributor

Concept ACK - All though I prefer @laanwj logo

I'm just disappointed it's taken this long to re-brand

JeremyCrookshank commented at 8:21 AM on April 1, 2020: contributor

Concept ACK 👍

dannmat commented at 8:21 AM on April 1, 2020: none

Concept NACK. I propse we rename to something more meaningful. Like Bitcoin Cash?

in configure.ac:9 in 7777c40abc outdated

   6 | @@ -7,8 +7,8 @@ define(_CLIENT_VERSION_RC, 0)
   7 |  define(_CLIENT_VERSION_IS_RELEASE, false)
   8 |  define(_COPYRIGHT_YEAR, 2020)
   9 |  define(_COPYRIGHT_HOLDERS,[The %s developers])

ajtowns commented at 8:39 AM on April 1, 2020:

"The %s corps" might be a better signal of the strength of our commitment to ensuring there is enough Bitcoin for everyone.

Aleru commented at 8:43 AM on April 1, 2020: none

lgtm, I think there should be some more work on the image eventually though.

emilengler commented at 9:14 AM on April 1, 2020: contributor

Concept ACK, but I suggest to switch to a more meaningful release tag like 1.0

theStack commented at 9:36 AM on April 1, 2020: member

Concept ACK -- this will make the user-adoption skyrocket!

May I suggest a small follow-up PR reflecting the new awesome logo: Changing the following annoying line https://github.com/bitcoin/bitcoin/blob/b97e3a73498bb49e81039e90e9cb5acdca9123cc/src/validation.cpp#L1228 to

nSubsidy <<= halvings;

With this modern monetary policy, we will fight poverty, and recreate social justice, a.k.a. everyone will be rich. I'm aware that the subsidy could overflow in the long run, but in the long run we will all be dead.

kiminuo commented at 10:45 AM on April 1, 2020: contributor

Concept ACK, thank you for working on this.

kek-coin commented at 10:57 AM on April 1, 2020: none

Concept ACK, I think this is really going with the times which is good, but also this only makes sense if it includes a fork to give a trillion BTC in stimulus measures to us.

I think we should let the free market decide which devs to reward - let's implement separate forks for each individual contributor to this repo (1 trillion BTC per dev) that can be individually signalled using version bits.

elichai commented at 11:03 AM on April 1, 2020: contributor

Concept ACK, can this get in time for 0.20?

nopara73 changes_requested

nopara73 commented at 11:05 AM on April 1, 2020: none

NACK. IMO it's misleading as it suggests Core can create more money out of thin air like central banks do, but that is not true.

promag commented at 11:09 AM on April 1, 2020: member

Thanks for working on this, at last something worth from you.

Code review ACK 7777c40abc7cba4303ceba7ff5d89cd6d7d0d23a. Could split in multiple commits and please add release notes and new test.

Building in XP, I'll let you know how that goes.

promag commented at 11:10 AM on April 1, 2020: member

Concept ACK, but I suggest to switch to a more meaningful release tag like 1.0 @emilengler imo we could jump into version 2 ME.

sr-gi commented at 11:25 AM on April 1, 2020: none

Concept ACK. However I saw that the project website has not been updated.

78079113-c16d7780-73ab-11ea-92db-b602909284a5

I got the new domain to prevent takeovers: https://bitcoincorrr.org/

Adjust project website to https://bitcoincorrr.org/ 444493e754

init: Replace URL_WEBSITE with PACKAGE_URL aaaabb873d

TheRec commented at 1:53 PM on April 1, 2020: none

LGTM... as in Let's Get This Money.

nshCore commented at 2:19 PM on April 1, 2020: none

Concept NACK. I propse we rename to something more meaningful. Like Bitcoin Cash?

digital cash was satoshi's original vision, maybe it should even moarrr meaningful and be called bitcoin satoshis original vision? has a ring I think

JosuGZ approved

JosuGZ commented at 2:33 PM on April 1, 2020: contributor

Concept ACK

benthecarman approved

bitbug42 commented at 8:24 PM on April 1, 2020: none

Very good improvement!

I'm also suggesting to remove this check: https://github.com/bitcoin/bitcoin/blob/41fa2926d86a57c9623d34debef20746ee2f454a/src/consensus/tx_verify.cpp#L187

I hate it when I can't spend the money I don't have, this is currently a major usability issue with Bitcoin. Fixing this will surely bring about mass adoption.