ci: Enable float-divide-by-zero check #27778

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2305-ci-float- changing 2 files +5 −2
  1. maflcko commented at 10:06 AM on May 30, 2023: member

    Enable it, because

    • It is enabled on OSS-Fuzz, so to be able to catch bugs earlier, enable it here as well.
    • It makes sense to enable, because when a float is divided by zero, it may be a logic bug in our code, so it should be suppressed in the suppressions file.
  2. ci: Enable float-divide-by-zero check fa3ab45203
  3. DrahtBot commented at 10:06 AM on May 30, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge, willcl-ark

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on May 30, 2023
  5. DrahtBot added the label CI failed on May 30, 2023
  6. dergoegge approved
  7. dergoegge commented at 2:03 PM on May 30, 2023: member

    ACK fa3ab4520317f48d4700b81dab023c4e639bbd68

  8. fanquake requested review from willcl-ark on May 30, 2023
  9. willcl-ark commented at 12:59 PM on May 31, 2023: member

    utACK fa3ab4520317f48d4700b81dab023c4e639bbd68

    The changes are straight forward-enough and I agree with the rationale, but I've been unable to test them locally due to unrealted build errors:

    <details> <summary>Details</summary>

    Making install in src
    make[1]: Entering directory '/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
    make[2]: Entering directory '/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
    rm -f libtest_util.a
    /usr/bin/ar cr libtest_util.a test/util/libtest_util_a-blockfilter.o test/util/libtest_util_a-coins.o test/util/libtest_util_a-json.o test/util/libtest_util_a-logging.o test/util/libtest_util_a-mining.o test/util/libtest_util_a-net.o test/util/libtest_util_a-script.o test/util/libtest_util_a-setup_common.o test/util/libtest_util_a-str.o test/util/libtest_util_a-transaction_utils.o test/util/libtest_util_a-txmempool.o test/util/libtest_util_a-validation.o wallet/test/libtest_util_a-util.o
    ranlib libtest_util.a
    rm -f libtest_fuzz.a
    /usr/bin/ar cr libtest_fuzz.a test/fuzz/libtest_fuzz_a-fuzz.o test/fuzz/libtest_fuzz_a-util.o test/fuzz/util/libtest_fuzz_a-mempool.o test/fuzz/util/libtest_fuzz_a-net.o
    ranlib libtest_fuzz.a
    rm -f libbitcoin_node.a
    /usr/bin/ar cr libbitcoin_node.a libbitcoin_node_a-addrdb.o libbitcoin_node_a-addrman.o libbitcoin_node_a-banman.o libbitcoin_node_a-blockencodings.o libbitcoin_node_a-blockfilter.o libbitcoin_node_a-chain.o consensus/libbitcoin_node_a-tx_verify.o libbitcoin_node_a-dbwrapper.o libbitcoin_node_a-deploymentstatus.o libbitcoin_node_a-flatfile.o libbitcoin_node_a-headerssync.o libbitcoin_node_a-httprpc.o libbitcoin_node_a-httpserver.o libbitcoin_node_a-i2p.o index/libbitcoin_node_a-base.o index/libbitcoin_node_a-blockfilterindex.o index/libbitcoin_node_a-coinstatsindex.o index/libbitcoin_node_a-txindex.o libbitcoin_node_a-init.o kernel/libbitcoin_node_a-chain.o kernel/libbitcoin_node_a-checks.o kernel/libbitcoin_node_a-coinstats.o kernel/libbitcoin_node_a-context.o kernel/libbitcoin_node_a-cs_main.o kernel/libbitcoin_node_a-mempool_persist.o libbitcoin_node_a-mapport.o libbitcoin_node_a-net.o libbitcoin_node_a-net_processing.o libbitcoin_node_a-netgroup.o node/libbitcoin_node_a-blockmanager_args.o node/libbitcoin_node_a-blockstorage.o node/libbitcoin_node_a-caches.o node/libbitcoin_node_a-chainstate.o node/libbitcoin_node_a-chainstatemanager_args.o node/libbitcoin_node_a-coin.o node/libbitcoin_node_a-coins_view_args.o node/libbitcoin_node_a-connection_types.o node/libbitcoin_node_a-context.o node/libbitcoin_node_a-database_args.o node/libbitcoin_node_a-eviction.o node/libbitcoin_node_a-interface_ui.o node/libbitcoin_node_a-interfaces.o node/libbitcoin_node_a-mempool_args.o node/libbitcoin_node_a-mempool_persist_args.o node/libbitcoin_node_a-miner.o node/libbitcoin_node_a-mini_miner.o node/libbitcoin_node_a-minisketchwrapper.o node/libbitcoin_node_a-psbt.o node/libbitcoin_node_a-transaction.o node/libbitcoin_node_a-txreconciliation.o node/libbitcoin_node_a-utxo_snapshot.o node/libbitcoin_node_a-validation_cache_args.o libbitcoin_node_a-noui.o policy/libbitcoin_node_a-fees.o policy/libbitcoin_node_a-fees_args.o policy/libbitcoin_node_a-packages.o policy/libbitcoin_node_a-rbf.o policy/libbitcoin_node_a-settings.o libbitcoin_node_a-pow.o libbitcoin_node_a-rest.o rpc/libbitcoin_node_a-blockchain.o rpc/libbitcoin_node_a-fees.o rpc/libbitcoin_node_a-mempool.o rpc/libbitcoin_node_a-mining.o rpc/libbitcoin_node_a-net.o rpc/libbitcoin_node_a-node.o rpc/libbitcoin_node_a-output_script.o rpc/libbitcoin_node_a-rawtransaction.o rpc/libbitcoin_node_a-server.o rpc/libbitcoin_node_a-server_util.o rpc/libbitcoin_node_a-signmessage.o rpc/libbitcoin_node_a-txoutproof.o script/libbitcoin_node_a-sigcache.o libbitcoin_node_a-shutdown.o libbitcoin_node_a-signet.o libbitcoin_node_a-timedata.o libbitcoin_node_a-torcontrol.o libbitcoin_node_a-txdb.o libbitcoin_node_a-txmempool.o libbitcoin_node_a-txorphanage.o libbitcoin_node_a-txrequest.o libbitcoin_node_a-validation.o libbitcoin_node_a-validationinterface.o libbitcoin_node_a-versionbits.o  wallet/libbitcoin_node_a-init.o
    ranlib libbitcoin_node.a
    rm -f libbitcoin_wallet.a
    /usr/bin/ar cr libbitcoin_wallet.a wallet/libbitcoin_wallet_a-coincontrol.o wallet/libbitcoin_wallet_a-context.o wallet/libbitcoin_wallet_a-crypter.o wallet/libbitcoin_wallet_a-db.o wallet/libbitcoin_wallet_a-dump.o wallet/libbitcoin_wallet_a-external_signer_scriptpubkeyman.o wallet/libbitcoin_wallet_a-feebumper.o wallet/libbitcoin_wallet_a-fees.o wallet/libbitcoin_wallet_a-interfaces.o wallet/libbitcoin_wallet_a-load.o wallet/libbitcoin_wallet_a-receive.o wallet/rpc/libbitcoin_wallet_a-addresses.o wallet/rpc/libbitcoin_wallet_a-backup.o wallet/rpc/libbitcoin_wallet_a-coins.o wallet/rpc/libbitcoin_wallet_a-encrypt.o wallet/rpc/libbitcoin_wallet_a-spend.o wallet/rpc/libbitcoin_wallet_a-signmessage.o wallet/rpc/libbitcoin_wallet_a-transactions.o wallet/rpc/libbitcoin_wallet_a-util.o wallet/rpc/libbitcoin_wallet_a-wallet.o wallet/libbitcoin_wallet_a-scriptpubkeyman.o wallet/libbitcoin_wallet_a-spend.o wallet/libbitcoin_wallet_a-transaction.o wallet/libbitcoin_wallet_a-wallet.o wallet/libbitcoin_wallet_a-walletdb.o wallet/libbitcoin_wallet_a-walletutil.o wallet/libbitcoin_wallet_a-coinselection.o  wallet/libbitcoin_wallet_a-sqlite.o
    ranlib libbitcoin_wallet.a
    rm -f libbitcoin_common.a
    /usr/bin/ar cr libbitcoin_common.a libbitcoin_common_a-base58.o libbitcoin_common_a-bech32.o libbitcoin_common_a-chainparams.o libbitcoin_common_a-coins.o common/libbitcoin_common_a-args.o common/libbitcoin_common_a-bloom.o common/libbitcoin_common_a-config.o common/libbitcoin_common_a-init.o common/libbitcoin_common_a-interfaces.o common/libbitcoin_common_a-run_command.o libbitcoin_common_a-compressor.o libbitcoin_common_a-core_read.o libbitcoin_common_a-core_write.o libbitcoin_common_a-deploymentinfo.o libbitcoin_common_a-external_signer.o init/libbitcoin_common_a-common.o kernel/libbitcoin_common_a-chainparams.o libbitcoin_common_a-key.o libbitcoin_common_a-key_io.o libbitcoin_common_a-merkleblock.o libbitcoin_common_a-net_types.o libbitcoin_common_a-netaddress.o libbitcoin_common_a-netbase.o libbitcoin_common_a-net_permissions.o libbitcoin_common_a-outputtype.o policy/libbitcoin_common_a-feerate.o policy/libbitcoin_common_a-policy.o libbitcoin_common_a-protocol.o libbitcoin_common_a-psbt.o rpc/libbitcoin_common_a-external_signer.o rpc/libbitcoin_common_a-rawtransaction_util.o rpc/libbitcoin_common_a-request.o rpc/libbitcoin_common_a-util.o libbitcoin_common_a-scheduler.o script/libbitcoin_common_a-descriptor.o script/libbitcoin_common_a-miniscript.o script/libbitcoin_common_a-sign.o script/libbitcoin_common_a-signingprovider.o script/libbitcoin_common_a-standard.o libbitcoin_common_a-warnings.o  common/libbitcoin_common_a-url.o
    ranlib libbitcoin_common.a
    ../share/genbuild.sh "/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/obj/build.h" \
      "/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu"
    rm -f libbitcoin_util.a
    /usr/bin/ar cr libbitcoin_util.a support/libbitcoin_util_a-lockedpool.o libbitcoin_util_a-chainparamsbase.o libbitcoin_util_a-clientversion.o libbitcoin_util_a-logging.o libbitcoin_util_a-random.o libbitcoin_util_a-randomenv.o support/libbitcoin_util_a-cleanse.o libbitcoin_util_a-sync.o util/libbitcoin_util_a-asmap.o util/libbitcoin_util_a-bip32.o util/libbitcoin_util_a-bytevectorhash.o util/libbitcoin_util_a-chaintype.o util/libbitcoin_util_a-check.o util/libbitcoin_util_a-error.o util/libbitcoin_util_a-exception.o util/libbitcoin_util_a-fees.o util/libbitcoin_util_a-fs.o util/libbitcoin_util_a-fs_helpers.o util/libbitcoin_util_a-getuniquepath.o util/libbitcoin_util_a-hasher.o util/libbitcoin_util_a-sock.o util/libbitcoin_util_a-syserror.o util/libbitcoin_util_a-system.o util/libbitcoin_util_a-message.o util/libbitcoin_util_a-moneystr.o util/libbitcoin_util_a-rbf.o util/libbitcoin_util_a-readwritefile.o util/libbitcoin_util_a-settings.o util/libbitcoin_util_a-thread.o util/libbitcoin_util_a-threadinterrupt.o util/libbitcoin_util_a-threadnames.o util/libbitcoin_util_a-serfloat.o util/libbitcoin_util_a-spanparsing.o util/libbitcoin_util_a-strencodings.o util/libbitcoin_util_a-string.o util/libbitcoin_util_a-syscall_sandbox.o util/libbitcoin_util_a-time.o util/libbitcoin_util_a-tokenpipe.o
    ranlib libbitcoin_util.a
    rm -f libbitcoin_consensus.a
    /usr/bin/ar cr libbitcoin_consensus.a libbitcoin_consensus_a-arith_uint256.o consensus/libbitcoin_consensus_a-merkle.o consensus/libbitcoin_consensus_a-tx_check.o libbitcoin_consensus_a-hash.o primitives/libbitcoin_consensus_a-block.o primitives/libbitcoin_consensus_a-transaction.o libbitcoin_consensus_a-pubkey.o script/libbitcoin_consensus_a-bitcoinconsensus.o script/libbitcoin_consensus_a-interpreter.o script/libbitcoin_consensus_a-script.o script/libbitcoin_consensus_a-script_error.o libbitcoin_consensus_a-uint256.o util/libbitcoin_consensus_a-strencodings.o
    ranlib libbitcoin_consensus.a
    /bin/bash ../libtool  --tag=CXX --preserve-dup-deps  --mode=compile /usr/bin/ccache clang++-16 -ftrivial-auto-var-init=pattern -std=c++17 -DHAVE_CONFIG_H -I. -I../src/config  -DABORT_ON_FAILED_ASSUME -fmacro-prefix-map=/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -DHAVE_BUILD_INFO  -fdebug-prefix-map=/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection   -Werror  -fsanitize=fuzzer,address,undefined,float-divide-by-zero,integer   -fPIE -static -Wno-suggest-override -c -o crypto/libbitcoin_crypto_base_la-sha256_sse4.lo `test -f 'crypto/sha256_sse4.cpp' || echo './'`crypto/sha256_sse4.cpp
    libtool: compile:  /usr/bin/ccache clang++-16 -ftrivial-auto-var-init=pattern -std=c++17 -DHAVE_CONFIG_H -I. -I../src/config -DABORT_ON_FAILED_ASSUME -fmacro-prefix-map=/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -DHAVE_BUILD_INFO -fdebug-prefix-map=/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu=. -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Werror -fsanitize=fuzzer,address,undefined,float-divide-by-zero,integer -Wno-suggest-override -c crypto/sha256_sse4.cpp  -fPIC -DPIC -o crypto/libbitcoin_crypto_base_la-sha256_sse4.o
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:1882: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:2591: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:3284: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:4686: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:5395: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:6088: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:7490: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:8199: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:8892: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:10312: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:11021: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:11714: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:12859: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:13356: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:13853: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:14900: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:15397: note: instantiated into assembly here
    crypto/sha256_sse4.cpp:44:9: error: expected relocatable expression
            "shl    $0x6,%2;"
            ^
    <inline asm>:1:15894: note: instantiated into assembly here
    18 errors generated.
    make[2]: *** [Makefile:14207: crypto/libbitcoin_crypto_base_la-sha256_sse4.lo] Error 1
    make[2]: Leaving directory '/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
    make[1]: *** [Makefile:19821: install-recursive] Error 1
    make[1]: Leaving directory '/home/will/src/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src'
    make: *** [Makefile:815: install-recursive] Error 1
    

    </details>

  10. DrahtBot removed review request from willcl-ark on May 31, 2023
  11. hebasto commented at 1:30 PM on May 31, 2023: member

    I've been unable to test them locally due to unrealted build errors:

    Mind providing more detailed steps to reproduce the failure?

  12. maflcko commented at 1:36 PM on May 31, 2023: member

    It probably depends on the CPU model to reproduce the unrelated failure?

  13. fanquake commented at 1:36 PM on May 31, 2023: member

    Mind providing more detailed steps to reproduce the failure?

    Clearly those failures are unrelated to this change.

  14. fanquake commented at 1:42 PM on May 31, 2023: member

    Checked that this found the previously fixed related failure, on aarch64, running the ASAN job:

    test/argsman_tests.cpp(169): Entering test case "util_CheckValue"
    validation.cpp:2839:5: runtime error: division by zero
        [#0](/bitcoin-bitcoin/0/) 0xaaaab0a4c198 in Chainstate::ConnectTip(BlockValidationState&, CBlockIndex*, std::shared_ptr<CBlock const> const&, ConnectTrace&, DisconnectedBlockTransactions&) src/validation.cpp:2839:5
        [#1](/bitcoin-bitcoin/1/) 0xaaaab0a506a0 in Chainstate::ActivateBestChainStep(BlockValidationState&, CBlockIndex*, std::shared_ptr<CBlock const> const&, bool&, ConnectTrace&) src/validation.cpp:3036:18
        [#2](/bitcoin-bitcoin/2/) 0xaaaab0a51940 in Chainstate::ActivateBestChain(BlockValidationState&, std::shared_ptr<CBlock const>) src/validation.cpp:3171:22
        [#3](/bitcoin-bitcoin/3/) 0xaaaaafd046d4 in ChainTestingSetup::LoadVerifyActivateChainstate() src/test/util/setup_common.cpp:241:38
        [#4](/bitcoin-bitcoin/4/) 0xaaaaafd053c8 in TestingSetup::TestingSetup(ChainType, std::vector<char const*, std::allocator<char const*>> const&, bool, bool) src/test/util/setup_common.cpp:259:5
        [#5](/bitcoin-bitcoin/5/) 0xaaaaafd06560 in TestChain100Setup::TestChain100Setup(ChainType, std::vector<char const*, std::allocator<char const*>> const&, bool, bool) src/test/util/setup_common.cpp:282:7
        [#6](/bitcoin-bitcoin/6/) 0xaaaaae987280 in argsman_tests::CheckValueTest::CheckValueTest() src/test/argsman_tests.cpp:84:7
        [#7](/bitcoin-bitcoin/7/) 0xaaaaae987280 in argsman_tests::util_CheckValue::util_CheckValue() src/test/argsman_tests.cpp:169:1
        [#8](/bitcoin-bitcoin/8/) 0xaaaaae987280 in argsman_tests::util_CheckValue_invoker() src/test/argsman_tests.cpp:169:1
        [#9](/bitcoin-bitcoin/9/) 0xaaaaae7c8bec in boost::function0<void>::operator()() const /usr/include/boost/function/function_template.hpp:763:14
        [#10](/bitcoin-bitcoin/10/) 0xaaaaae8468b8 in boost::detail::forward::operator()() /usr/include/boost/test/impl/execution_monitor.ipp:1388:32
        [#11](/bitcoin-bitcoin/11/) 0xaaaaae8468b8 in boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke(boost::detail::function::function_buffer&) /usr/include/boost/function/function_template.hpp:137:18
        [#12](/bitcoin-bitcoin/12/) 0xaaaaae83fd20 in boost::function0<int>::operator()() const /usr/include/boost/function/function_template.hpp:763:14
        [#13](/bitcoin-bitcoin/13/) 0xaaaaae715bd8 in int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()>>(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) /usr/include/boost/test/impl/execution_monitor.ipp:301:30
        [#14](/bitcoin-bitcoin/14/) 0xaaaaae715bd8 in boost::execution_monitor::catch_signals(boost::function<int ()> const&) /usr/include/boost/test/impl/execution_monitor.ipp:903:16
        [#15](/bitcoin-bitcoin/15/) 0xaaaaae716008 in boost::execution_monitor::execute(boost::function<int ()> const&) /usr/include/boost/test/impl/execution_monitor.ipp:1301:16
        [#16](/bitcoin-bitcoin/16/) 0xaaaaae708018 in boost::execution_monitor::vexecute(boost::function<void ()> const&) /usr/include/boost/test/impl/execution_monitor.ipp:1397:5
        [#17](/bitcoin-bitcoin/17/) 0xaaaaae70ed04 in boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned long) /usr/include/boost/test/impl/unit_test_monitor.ipp:49:9
        [#18](/bitcoin-bitcoin/18/) 0xaaaaae78876c in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /usr/include/boost/test/impl/framework.ipp:815:44
        [#19](/bitcoin-bitcoin/19/) 0xaaaaae787750 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /usr/include/boost/test/impl/framework.ipp:784:58
        [#20](/bitcoin-bitcoin/20/) 0xaaaaae787750 in boost::unit_test::framework::state::execute_test_tree(unsigned long, unsigned long, boost::unit_test::framework::state::random_generator_helper const*) /usr/include/boost/test/impl/framework.ipp:784:58
        [#21](/bitcoin-bitcoin/21/) 0xaaaaae70d0bc in boost::unit_test::framework::run(unsigned long, bool) /usr/include/boost/test/impl/framework.ipp:1721:29
        [#22](/bitcoin-bitcoin/22/) 0xaaaaae73e268 in boost::unit_test::unit_test_main(boost::unit_test::test_suite* (*)(int, char**), int, char**) /usr/include/boost/test/impl/unit_test_main.ipp:250:9
        [#23](/bitcoin-bitcoin/23/) 0xffff7f266dbc  (/lib/aarch64-linux-gnu/libc.so.6+0x26dbc) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
        [#24](/bitcoin-bitcoin/24/) 0xffff7f266e94 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x26e94) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
        [#25](/bitcoin-bitcoin/25/) 0xaaaaae60f82c in _start (/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/test_bitcoin+0x10af82c) (BuildId: 9759687ccc4ec7ebe7ede75bcf67edb8db43481f)
    
    SUMMARY: UndefinedBehaviorSanitizer: float-divide-by-zero validation.cpp:2839:5 in 
    make[3]: *** [Makefile:22185: test/argsman_tests.cpp.test] Error 1
    FAIL: qt/test/test_bitcoin-qt
    ==============================================
       Bitcoin Core 25.99.0: src/test-suite.log
    ==============================================
    
    # TOTAL: 4
    # PASS:  3
    # SKIP:  0
    # XFAIL: 0
    # FAIL:  1
    # XPASS: 0
    # ERROR: 0
    
    .. contents:: :depth: 2
    
    FAIL: qt/test/test_bitcoin-qt
    =============================
    
    QStandardPaths: error creating runtime directory '/run/user/1000' (No such file or directory)
    ********* Start testing of AppTests *********
    Config: Using QtTest library 5.15.8, Qt 5.15.8 (arm64-little_endian-lp64 shared (dynamic) release build; by GCC 12.2.0), ubuntu 23.04
    PASS   : AppTests::initTestCase()
    QINFO  : AppTests::appTests() Backing up GUI settings to "/tmp/test_common_Bitcoin Core/ab708ec6c995f602aa6c36a54e78b220fe629a5ea540e7822a07179cb10c4052/regtest/guisettings.ini.bak"
    QDEBUG : AppTests::appTests() requestInitialize : Requesting initialize
    QDEBUG : AppTests::appTests() Running initialization in thread
    validation.cpp:2839:5: runtime error: division by zero
        [#0](/bitcoin-bitcoin/0/) 0xaaaac4a7cb18 in Chainstate::ConnectTip(BlockValidationState&, CBlockIndex*, std::shared_ptr<CBlock const> const&, ConnectTrace&, DisconnectedBlockTransactions&) src/validation.cpp:2839:5
        [#1](/bitcoin-bitcoin/1/) 0xaaaac4a81020 in Chainstate::ActivateBestChainStep(BlockValidationState&, CBlockIndex*, std::shared_ptr<CBlock const> const&, bool&, ConnectTrace&) src/validation.cpp:3036:18
        [#2](/bitcoin-bitcoin/2/) 0xaaaac4a822c0 in Chainstate::ActivateBestChain(BlockValidationState&, std::shared_ptr<CBlock const>) src/validation.cpp:3171:22
        [#3](/bitcoin-bitcoin/3/) 0xaaaac4581260 in node::ThreadImport(ChainstateManager&, std::vector<fs::path, std::allocator<fs::path>>, fs::path const&) src/node/blockstorage.cpp:930:30
        [#4](/bitcoin-bitcoin/4/) 0xaaaac43a989c in AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13::operator()() const src/init.cpp:1680:9
        [#5](/bitcoin-bitcoin/5/) 0xaaaac43a989c in void std::__invoke_impl<void, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&>(std::__invoke_other, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&) /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:61:14
        [#6](/bitcoin-bitcoin/6/) 0xaaaac43a989c in std::enable_if<is_invocable_r_v<void, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&>, void>::type std::__invoke_r<void, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&>(AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&) /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:111:2
        [#7](/bitcoin-bitcoin/7/) 0xaaaac43a989c in std::_Function_handler<void (), AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>::_M_invoke(std::_Any_data const&) /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/std_function.h:290:9
        [#8](/bitcoin-bitcoin/8/) 0xaaaac4d48790 in std::function<void ()>::operator()() const /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/std_function.h:591:9
        [#9](/bitcoin-bitcoin/9/) 0xaaaac4d48790 in util::TraceThread(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>) src/util/thread.cpp:21:9
        [#10](/bitcoin-bitcoin/10/) 0xaaaac43a948c in void std::__invoke_impl<void, void (*)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>(std::__invoke_other, void (*&&)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*&&, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:61:14
        [#11](/bitcoin-bitcoin/11/) 0xaaaac43a948c in std::__invoke_result<void (*)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>::type std::__invoke<void (*)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>(void (*&&)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*&&, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/invoke.h:96:14
        [#12](/bitcoin-bitcoin/12/) 0xaaaac43a948c in void std::thread::_Invoker<std::tuple<void (*)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>>::_M_invoke<0ul, 1ul, 2ul>(std::_Index_tuple<0ul, 1ul, 2ul>) /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/std_thread.h:252:13
        [#13](/bitcoin-bitcoin/13/) 0xaaaac43a948c in std::thread::_Invoker<std::tuple<void (*)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>>::operator()() /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/std_thread.h:259:11
        [#14](/bitcoin-bitcoin/14/) 0xaaaac43a948c in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(std::basic_string_view<char, std::char_traits<char>>, std::function<void ()>), char const*, AppInitMain(node::NodeContext&, interfaces::BlockAndHeaderTipInfo*)::$_13>>>::_M_run() /usr/bin/../lib/gcc/aarch64-linux-gnu/12/../../../../include/c++/12/bits/std_thread.h:210:13
        [#15](/bitcoin-bitcoin/15/) 0xffffa194b958  (/lib/aarch64-linux-gnu/libstdc++.so.6+0xdb958) (BuildId: f99b2ebee221feb14356743021c89e3f000a59e1)
        [#16](/bitcoin-bitcoin/16/) 0xffffa161e810  (/lib/aarch64-linux-gnu/libc.so.6+0x7e810) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
        [#17](/bitcoin-bitcoin/17/) 0xffffa1687d58  (/lib/aarch64-linux-gnu/libc.so.6+0xe7d58) (BuildId: 9efe43e32e614cad22a180ef036eea6154eafdc2)
    
    SUMMARY: UndefinedBehaviorSanitizer: float-divide-by-zero validation.cpp:2839:5 in 
    FAIL qt/test/test_bitcoin-qt (exit status: 1)
    
    ============================================================================
    Testsuite summary for Bitcoin Core 25.99.0
    ============================================================================
    # TOTAL: 4
    # PASS:  3
    # SKIP:  0
    # XFAIL: 0
    # FAIL:  1
    # XPASS: 0
    # ERROR: 0
    ============================================================================
    See src/test-suite.log
    Please report to https://github.com/bitcoin/bitcoin/issues
    ============================================================================
    make[4]: *** [Makefile:19929: test-suite.log] Error 1
    make[4]: Leaving directory '/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
    make[3]: *** [Makefile:20037: check-TESTS] Error 2
    make[3]: Leaving directory '/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
    make[2]: *** [Makefile:20156: check-am] Error 2
    make[2]: Leaving directory '/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
    make[1]: *** [Makefile:19821: check-recursive] Error 1
    make[1]: Leaving directory '/home/fedora/ci_scratch/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src'
    make: *** [Makefile:815: check-recursive] Error 1
    
  15. fanquake merged this on May 31, 2023
  16. fanquake closed this on May 31, 2023

  17. maflcko deleted the branch on May 31, 2023
  18. sidhujag referenced this in commit 3741d12c36 on May 31, 2023
  19. bitcoin locked this on May 30, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me