ci: enable AArch64 target in MSAN jobs #27824

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:msan_aarch64 changing 1 files +3 −3

fanquake commented at 11:04 AM on June 5, 2023: member

Make it possible to run the MSAN jobs on aarch64, as it was previously.
ci: use LLVM 16.0.5 in MSAN jobs c93bfc54e8
DrahtBot commented at 11:05 AM on June 5, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot renamed this:
~~ci: enable AArch64 target in MSAN jobs~~
ci: enable AArch64 target in MSAN jobs
on Jun 5, 2023
DrahtBot added the label Tests on Jun 5, 2023

Type	Reviewers
ACK	dergoegge

in ci/test/01_base_install.sh:49 in 6a6ecf0374 outdated

  46 | +  git clone --depth=1 https://github.com/llvm/llvm-project -b llvmorg-16.0.5 "${BASE_SCRATCH_DIR}"/msan/llvm-project
  47 |  
  48 |    cmake -G Ninja -B "${BASE_SCRATCH_DIR}"/msan/clang_build/ -DLLVM_ENABLE_PROJECTS="clang" \
  49 |                                                              -DCMAKE_BUILD_TYPE=Release \
  50 | -                                                            -DLLVM_TARGETS_TO_BUILD=X86 \
  51 | +                                                            -DLLVM_TARGETS_TO_BUILD="X86;AArch64" \

maflcko commented at 11:12 AM on June 5, 2023:

will this build both? Would be nice to just detect and build for the current CPU, if that is possible?

hebasto commented at 11:57 AM on June 5, 2023:

Would be nice to just detect and build for the current CPU, if that is possible?

What about not providing the value at all, and using the default one?

fanquake commented at 2:41 PM on June 5, 2023:

if that is possible?

Done with Native.

DrahtBot added the label CI failed on Jun 5, 2023
ci: enable AArch64 target in MSAN jobs
Use Native.
2ebeb421dd
fanquake force-pushed on Jun 5, 2023
fanquake requested review from dergoegge on Jun 6, 2023
dergoegge approved
dergoegge commented at 9:24 AM on June 7, 2023: member

utACK 2ebeb421dd21a69344a32c681ccbfcf5e5c6dab9
fanquake merged this on Jun 7, 2023
fanquake closed this on Jun 7, 2023
fanquake deleted the branch on Jun 7, 2023
sidhujag referenced this in commit 71ce3e2a41 on Jun 7, 2023
hebasto commented at 4:20 PM on June 13, 2023: member

Post-merge ACK 2ebeb421dd21a69344a32c681ccbfcf5e5c6dab9. Tested on Ubuntu 23.04, aarch64.

FWIW, the default value, i.e., not setting LLVM_TARGETS_TO_BUILD altogether, works as well.
bitcoin locked this on Dec 5, 2024

Contributors

Labels

ci: enable AArch64 target in MSAN jobs #27824

Reviews