ci: clang-17 for fuzz and tsan #28465

1. 
   MarcoFalke commented at 7:33 am on September 13, 2023: member

   Bump clang in CI from 16 to 17, to:

   • Bump the CI “EOL” from Jan 2024 to July 2024, by bumping from Ubuntu lunar to mantic
   • Test, ensure compatibility, and make use of any new sanitizer features in clang-17
2. 
   DrahtBot commented at 7:33 am on September 13, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge
   Concept ACK	fanquake, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Sep 13, 2023
4. MarcoFalke added this to the milestone 26.0 on Sep 13, 2023
5. MarcoFalke force-pushed on Sep 13, 2023
6. DrahtBot added the label CI failed on Sep 13, 2023
7. 
   MarcoFalke commented at 8:11 am on September 13, 2023: member

   Looks like tidy fails with an error:

   0clang-tidy-17 -p=/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz.cpp
   1test/fuzz/fuzz.cpp:94:34: error: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl,-warnings-as-errors]
   2   94 |             std::cout << name << std::endl;
   3      |                                  ^~~~~~~~~
   4      |                                  '\n'
   

   So I’ll postpone that for now.

8. MarcoFalke force-pushed on Sep 13, 2023
9. 
   fanquake commented at 8:49 am on September 13, 2023: member

   Concept ACK. Could probably just disable performance-avoid-endl.
10. 
    hebasto commented at 9:27 am on September 13, 2023: member

    Concept ACK.
11. 
    MarcoFalke commented at 9:58 am on September 13, 2023: member

    Looks like USDT is broken as well on Mantic, regardless of the clang version: #28467 (comment)

    Going to drop that as well, for now.

12. MarcoFalke force-pushed on Sep 13, 2023
13. 
    dergoegge commented at 10:10 am on September 13, 2023: member

    Concept ACK
14. in ci/test/01_base_install.sh:48 in 6a7a0bfe33 outdated

    41@@ -42,7 +42,7 @@ if [ -n "$PIP_PACKAGES" ]; then
    42 fi
    43 
    44 if [[ ${USE_MEMORY_SANITIZER} == "true" ]]; then
    45-  git clone --depth=1 https://github.com/llvm/llvm-project -b llvmorg-16.0.6 /msan/llvm-project
    46+  git clone --depth=1 https://github.com/llvm/llvm-project -b "llvmorg-17.0.0-rc4" /msan/llvm-project
    47 
    48   cmake -G Ninja -B /msan/clang_build/ \
    49     -DLLVM_ENABLE_PROJECTS="clang" \
    

    ---

    ---

    

    MarcoFalke commented at 11:31 am on September 13, 2023:

    unrelated: MAKEJOBS does not work in this file, when building the docker image. Not sure what the best fix is for this.
15. 
    MarcoFalke commented at 11:33 am on September 13, 2023: member

    Looks like msan also fails:

    0-- Performing Test CXX_SUPPORTS_GLINE_TABLES_ONLY_FLAG - Success
    1CMake Error at /msan/llvm-project/libcxx/CMakeLists.txt:763 (message):
    2  LIBCXX_ENABLE_ASSERTIONS has been replaced by
    3  LIBCXX_HARDENING_MODE=hardened
    4
    5
    6-- Configuring incomplete, errors occurred!
    

    So I’ll drop that as well for now.

16. ci: clang-17 for fuzz and tsan fa23c9aa7c
17. MarcoFalke renamed this:
    ci: clang-17
    ci: clang-17 for fuzz and tsan
    on Sep 13, 2023
18. MarcoFalke force-pushed on Sep 13, 2023
19. DrahtBot removed the label CI failed on Sep 13, 2023
20. 
    MarcoFalke commented at 1:46 pm on September 13, 2023: member

    This is ready for review. Follow-ups that need more work:

    • tidy/iwyu: #28465 (comment)
    • Asan USDT: #28465 (comment)
    • msan: #28465 (comment)
21. fanquake approved
22. 
    fanquake commented at 2:52 pm on September 13, 2023: member

    lgtm fa23c9aa7c7d60ff4f914447e7d37dedca85e171 - I can followup with MSAN & tidy
23. 
    MarcoFalke commented at 3:17 pm on September 13, 2023: member

    iwyu doesn’t have a branch, so I think tidy will need to wait either way. Though, msan can be done, and shouldn’t conflict with this pull in any way.
24. dergoegge approved
25. 
    dergoegge commented at 10:04 am on September 14, 2023: member

    utACK fa23c9aa7c7d60ff4f914447e7d37dedca85e171
26. fanquake merged this on Sep 14, 2023
27. fanquake closed this on Sep 14, 2023

    ---

28. MarcoFalke deleted the branch on Sep 14, 2023

Contributors
MarcoFalke DrahtBot fanquake hebasto dergoegge

Labels
Tests

Milestone
26.0