test: add TestNode wait_until helper #29070

pull nikodemas wants to merge 1 commits into bitcoin:master from nikodemas:tests_add_wait_helper changing 1 files +7 −5

nikodemas commented at 10:26 AM on December 13, 2023: contributor

Add wait_until method that wraps the wait_until_helper_internal call.

Closes #29029.
test: add TestNode wait_until helper bf0f7dbec6
DrahtBot commented at 10:26 AM on December 13, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK maflcko, BrandonOdiwuor, mohamedawnallah, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Dec 13, 2023
maflcko commented at 10:36 AM on December 13, 2023: member

lgtm ACK bf0f7dbec6590a54ec890e7a2ca5d85427995334
DrahtBot added the label CI failed on Dec 13, 2023
BrandonOdiwuor approved
BrandonOdiwuor commented at 3:05 PM on December 13, 2023: contributor

Code review ACK bf0f7dbec6590a54ec890e7a2ca5d85427995334

Looks good to me
mohamedawnallah commented at 3:24 PM on December 13, 2023: none

LGTM! Code Review ACK https://github.com/bitcoin/bitcoin/commit/bf0f7dbec6590a54ec890e7a2ca5d85427995334
achow101 commented at 7:10 PM on December 14, 2023: member

ACK bf0f7dbec6590a54ec890e7a2ca5d85427995334
achow101 merged this on Dec 14, 2023
achow101 closed this on Dec 14, 2023
bitcoin locked this on Dec 13, 2024