depends: Bump libmultiprocess for CMake fixes #30513

1. 
   hebasto commented at 6:45 pm on July 23, 2024: member

   This PR amends #30490 and bumps the upstream branch, which now includes a required CMake fix.

   Addresses #30490 (comment).

   The CI logs are available in #29790 where the recent push uses this PR implementation.

2. hebasto added the label Build system on Jul 23, 2024
3. 
   DrahtBot commented at 6:45 pm on July 23, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	ryanofsky, theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   hebasto commented at 6:46 pm on July 23, 2024: member

   cc @ryanofsky @theuni
5. hebasto added the label Needs CMake port on Jul 23, 2024
6. 
   fanquake commented at 6:49 pm on July 23, 2024: member

   Any reason to not include the most recent merge?
7. 
   ryanofsky commented at 7:00 pm on July 23, 2024: contributor

   Any reason to not include the most recent merge?

   It would be nice to include https://github.com/chaincodelabs/libmultiprocess/pull/104 not just https://github.com/chaincodelabs/libmultiprocess/pull/103, though only 103 should be necessary to fix problems with CMake.

   104 is just nice because it lets earlier commits of #30510 compile, since they include empty structs.

8. 
   fanquake commented at 7:02 pm on July 23, 2024: member

   Seems good to pull it in then, and unblock other work, otherwise we are just going to have to bump again.
9. ryanofsky approved
10. 
    ryanofsky commented at 7:04 pm on July 23, 2024: contributor

    Code review ACK a9bfa3abbe5c168230b20b756034c3801244d717

    (checked version hash locally and ran make MULTIPROCESS=1 native_libmultiprocess_extracted to check the package hash)

11. depends: Bump `libmultiprocess` for CMake fixes ec0e805d11
12. hebasto force-pushed on Jul 23, 2024
13. 
    hebasto commented at 7:06 pm on July 23, 2024: member

    It would be nice to include chaincodelabs/libmultiprocess#104 not just chaincodelabs/libmultiprocess#103, though only 103 should be necessary to fix problems with CMake.

    104 is just nice because it lets earlier commits of #30510 compile, since they include empty structs.

    https://github.com/chaincodelabs/libmultiprocess/pull/104 has been included.

14. ryanofsky approved
15. 
    ryanofsky commented at 7:08 pm on July 23, 2024: contributor

    Code review ACK ec0e805d11d6a73c542032fc49a58a1d05b62d24
16. theuni approved
17. 
    theuni commented at 8:25 pm on July 23, 2024: member

    Sorry for jumping the gun and causing extra churn with #30490. Hopefully this is the last bump for CMake :)

    utACK ec0e805d11d6a73c542032fc49a58a1d05b62d24.

18. 
    ryanofsky commented at 8:39 pm on July 23, 2024: contributor

    Sorry for jumping the gun and causing extra churn with #30490. Hopefully this is the last bump for CMake :)

    I probably should have asked about this when I reviewed #30490. I knew the cmake changes it included caused problems earlier, but I assumed the problems were fixed since then.

19. fanquake merged this on Jul 24, 2024
20. fanquake closed this on Jul 24, 2024

    ---

21. hebasto deleted the branch on Jul 24, 2024
22. hebasto referenced this in commit ead20f0e2d on Jul 24, 2024
23. 
    hebasto commented at 1:02 pm on July 24, 2024: member

    Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/277.
24. hebasto removed the label Needs CMake port on Jul 24, 2024

Contributors
hebasto DrahtBot fanquake ryanofsky theuni

Labels
Build system