This PR amends #30490 and bumps the upstream branch, which now includes a required CMake fix.
Addresses #30490 (comment).
The CI logs are available in #29790 where the recent push uses this PR implementation.
depends: Bump `libmultiprocess` for CMake fixes #30513
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240723-mp changing 1 files +2 −2-
hebasto commented at 6:45 PM on July 23, 2024: member
- hebasto added the label Build system on Jul 23, 2024
-
DrahtBot commented at 6:45 PM on July 23, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
hebasto commented at 6:46 PM on July 23, 2024: member
- hebasto added the label Needs CMake port on Jul 23, 2024
-
fanquake commented at 6:49 PM on July 23, 2024: member
Any reason to not include the most recent merge?
-
ryanofsky commented at 7:00 PM on July 23, 2024: contributor
Any reason to not include the most recent merge?
It would be nice to include https://github.com/chaincodelabs/libmultiprocess/pull/104 not just https://github.com/chaincodelabs/libmultiprocess/pull/103, though only 103 should be necessary to fix problems with CMake.
104 is just nice because it lets earlier commits of #30510 compile, since they include empty structs.
-
fanquake commented at 7:02 PM on July 23, 2024: member
Seems good to pull it in then, and unblock other work, otherwise we are just going to have to bump again.
- ryanofsky approved
-
ryanofsky commented at 7:04 PM on July 23, 2024: contributor
Code review ACK a9bfa3abbe5c168230b20b756034c3801244d717
(checked version hash locally and ran
make MULTIPROCESS=1 native_libmultiprocess_extractedto check the package hash) -
depends: Bump `libmultiprocess` for CMake fixes ec0e805d11
- hebasto force-pushed on Jul 23, 2024
-
hebasto commented at 7:06 PM on July 23, 2024: member
It would be nice to include chaincodelabs/libmultiprocess#104 not just chaincodelabs/libmultiprocess#103, though only 103 should be necessary to fix problems with CMake.
104 is just nice because it lets earlier commits of #30510 compile, since they include empty structs.
https://github.com/chaincodelabs/libmultiprocess/pull/104 has been included.
- ryanofsky approved
-
ryanofsky commented at 7:08 PM on July 23, 2024: contributor
Code review ACK ec0e805d11d6a73c542032fc49a58a1d05b62d24
- theuni approved
-
-
ryanofsky commented at 8:39 PM on July 23, 2024: contributor
- fanquake merged this on Jul 24, 2024
- fanquake closed this on Jul 24, 2024
- hebasto deleted the branch on Jul 24, 2024
- hebasto referenced this in commit ead20f0e2d on Jul 24, 2024
-
hebasto commented at 1:02 PM on July 24, 2024: member
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/277.
- hebasto removed the label Needs CMake port on Jul 24, 2024
- PastaPastaPasta referenced this in commit 50f31aee0c on Oct 3, 2024
- PastaPastaPasta referenced this in commit 7cdacdc1ad on Oct 3, 2024
- PastaPastaPasta referenced this in commit e5daf4a322 on Oct 4, 2024
- bitcoin locked this on Jul 24, 2025
