build: Add resource file and manifest to `bitcoin.exe`

hebasto commented at 7:26 pm on May 28, 2025: member

This PR is a follow up to #31375, which:

Adds a resource file for bitcoin.exe for consistency with other Windows executables.
Adds an application manifest to bitcoin.exe, which has been required for release binaries since #32396.

windows: Add resource file for `bitcoin.exe` df82c2dc17

windows: Add application manifest to `bitcoin.exe` dbb2d4c3d5

hebasto added the label Windows on May 28, 2025

hebasto added the label Build system on May 28, 2025

DrahtBot commented at 7:26 pm on May 28, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32634.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hodlinator, davidgumberg
Concept ACK	Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

in src/bitcoin-res.rc:17 in dbb2d4c3d5

12+BEGIN
13+    BLOCK "StringFileInfo"
14+    BEGIN
15+        BLOCK "040904E4" // U.S. English - multilingual (hex)
16+        BEGIN
17+            VALUE "CompanyName",        "Bitcoin"

hodlinator commented at 7:53 pm on May 28, 2025:

nit: Could update this for all existing RC files in commit prior to introducing this new file?

0            VALUE "CompanyName",        "Bitcoin Core"

hodlinator approved

hodlinator commented at 8:35 pm on May 28, 2025: contributor

ACK dbb2d4c3d54759f8c346882b6f98d26d5bb8e816

(Apologies for not catching this as I reviewed both of the conflicting PRs).

Ran into a similar issue yesterday when temporarily including bench_bitcoin.exe in a Windows Guix build to verify an optimization. See the collapsed “Patch” section under the “Guix + Windows” heading in #31144#pullrequestreview-2874254446.

Diffed new .rc file against bitcoind-res.rc to confirm only reasonable content differs.

Testing

Ran Windows Guix build on PR base (88b22acc3d6faeb2c0860695783a2a082d4c8098) and got expected error: /distsrc-base/distsrc-88b22acc3d6f-x86_64-w64-mingw32/build/bin/bitcoin.exe: failed APPLICATION_MANIFEST

Building the same on PR tip (dbb2d4c3d54759f8c346882b6f98d26d5bb8e816) succeeds.

davidgumberg commented at 2:50 am on May 29, 2025: contributor

ACK https://github.com/bitcoin/bitcoin/pull/32634/commits/dbb2d4c3d54759f8c346882b6f98d26d5bb8e816

Might be nice to have a CI check like https://github.com/davidgumberg/bitcoin/commit/1b9816052b1d8ad1d9c17945530e14ead79fce33 to prevent future regressions, but OK for a separate PR if out of scope.

This is also a blocker for #32431.

Sjors commented at 6:57 am on May 29, 2025: member

Concept ACK, seems consistent with the other binaries. I made a note to test a guix build on Windows later (assuming this does anything without code signing?).

fanquake commented at 9:40 am on May 29, 2025: member

Guix Build:

 00762b5cbe6135d2e83b80f96248be668bb5ac514511b07f59fbd1df5094d9eee  guix-build-dbb2d4c3d547/output/aarch64-linux-gnu/SHA256SUMS.part
 1c65f1e1fe6feb729acd0b987066d7131e5e7220c1e45c6731f9e46e1b2dca187  guix-build-dbb2d4c3d547/output/aarch64-linux-gnu/bitcoin-dbb2d4c3d547-aarch64-linux-gnu-debug.tar.gz
 205e4220765d4c85c5bfe89392e264b0c0cd6bd093fed2eb025f33cd9180f220c  guix-build-dbb2d4c3d547/output/aarch64-linux-gnu/bitcoin-dbb2d4c3d547-aarch64-linux-gnu.tar.gz
 3e0bb9020320a12cadd6acb1f59e72643c38d13730d4e79560221202792faf462  guix-build-dbb2d4c3d547/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e85fab77ac70456262bf5a11bb18712061b4b183aab9531d857bce6ddbf88d26  guix-build-dbb2d4c3d547/output/arm-linux-gnueabihf/bitcoin-dbb2d4c3d547-arm-linux-gnueabihf-debug.tar.gz
 5df7ce4d02a13cf68932eb3462d9ab643157af898272c3c2b8cdf64bafa3ad7e5  guix-build-dbb2d4c3d547/output/arm-linux-gnueabihf/bitcoin-dbb2d4c3d547-arm-linux-gnueabihf.tar.gz
 6c7d9de86d3ee46dade2bf45da7a03919018d8401410d984caa971bcb2df6860e  guix-build-dbb2d4c3d547/output/arm64-apple-darwin/SHA256SUMS.part
 7bf18b71ab2b23d9ab4465af43c428fffe384aa7c76ca83b6807f080c8516f914  guix-build-dbb2d4c3d547/output/arm64-apple-darwin/bitcoin-dbb2d4c3d547-arm64-apple-darwin-codesigning.tar.gz
 8274eeef0e3b92738c23e342788e482e3d2dc97acf65fcc92197d23c975287382  guix-build-dbb2d4c3d547/output/arm64-apple-darwin/bitcoin-dbb2d4c3d547-arm64-apple-darwin-unsigned.tar.gz
 9e77c82775109c50efe928f21bb158471d952bf5eeb86d92bedca3e3d4a106820  guix-build-dbb2d4c3d547/output/arm64-apple-darwin/bitcoin-dbb2d4c3d547-arm64-apple-darwin-unsigned.zip
1027604622ce4728c2a3d4795d310cc9a774796f8bc744ddc2d585fce05dbe44d6  guix-build-dbb2d4c3d547/output/dist-archive/bitcoin-dbb2d4c3d547.tar.gz
11ea53c6bf802b8caaacef2e39755bcbfa1c1f81e8d27c8e884e4c701ccde5ed20  guix-build-dbb2d4c3d547/output/powerpc64-linux-gnu/SHA256SUMS.part
12fa822d6225bd617f233ff0de569823e57728509b976a2a15f3b2df708117666c  guix-build-dbb2d4c3d547/output/powerpc64-linux-gnu/bitcoin-dbb2d4c3d547-powerpc64-linux-gnu-debug.tar.gz
132687c6e337b55434f13bce1a6d937120e757cbcd1c20d1b1d3054cb76b5b92a7  guix-build-dbb2d4c3d547/output/powerpc64-linux-gnu/bitcoin-dbb2d4c3d547-powerpc64-linux-gnu.tar.gz
14209f9b97d07920039391a957b7380c81431f7752f6c07f00dd182fea191178d1  guix-build-dbb2d4c3d547/output/riscv64-linux-gnu/SHA256SUMS.part
153f3df816ac88daa41fc059aa044d611509ffbcd2388cfcc9d1dfe1d940e629a6  guix-build-dbb2d4c3d547/output/riscv64-linux-gnu/bitcoin-dbb2d4c3d547-riscv64-linux-gnu-debug.tar.gz
16b9303e7e870099c9737531322eeebd84ee806433ac51cfc1a3fce08a5d72a750  guix-build-dbb2d4c3d547/output/riscv64-linux-gnu/bitcoin-dbb2d4c3d547-riscv64-linux-gnu.tar.gz
17ff520d86512d8346d93548c4874489034e4379244821a80663e8161434543bbe  guix-build-dbb2d4c3d547/output/x86_64-apple-darwin/SHA256SUMS.part
18fe718b09e41d6c964e0b68cb5cf939e16bbc669b483194a261326bcd65279831  guix-build-dbb2d4c3d547/output/x86_64-apple-darwin/bitcoin-dbb2d4c3d547-x86_64-apple-darwin-codesigning.tar.gz
19d52d6a880c9495aaacd8891520e8f09d7e402358d98f64794a71da61d5670ed4  guix-build-dbb2d4c3d547/output/x86_64-apple-darwin/bitcoin-dbb2d4c3d547-x86_64-apple-darwin-unsigned.tar.gz
207f8611320fce39aa4be6878e95ac4ca00e879ad5cc7b1b7d045f50e767a77f9e  guix-build-dbb2d4c3d547/output/x86_64-apple-darwin/bitcoin-dbb2d4c3d547-x86_64-apple-darwin-unsigned.zip
219471fc34f66addac4e6956a35128616c294cb6d756555917d10f43336de6d84b  guix-build-dbb2d4c3d547/output/x86_64-linux-gnu/SHA256SUMS.part
22be7f11f8e651e6c94814609e33d57ff2357cdd242eddefc640a0c11f33923f26  guix-build-dbb2d4c3d547/output/x86_64-linux-gnu/bitcoin-dbb2d4c3d547-x86_64-linux-gnu-debug.tar.gz
233fbe22c1e88915e666374538a057e011691a845d72150be552dc0b9c7b74bf49  guix-build-dbb2d4c3d547/output/x86_64-linux-gnu/bitcoin-dbb2d4c3d547-x86_64-linux-gnu.tar.gz
248ff25d176d59a4ec0de0ffeb9dc720865785c4dbf77ee651f62e94593c391c24  guix-build-dbb2d4c3d547/output/x86_64-w64-mingw32/SHA256SUMS.part
257210eb474a71510d5a15dd45c8628b1c5b36450f2f5d247a02a248589098d53b  guix-build-dbb2d4c3d547/output/x86_64-w64-mingw32/bitcoin-dbb2d4c3d547-win64-codesigning.tar.gz
26c92ab6bd518cb5cdf99081ce02cfdb4db0daaab7c1b56c0bcf22e62aec3742b7  guix-build-dbb2d4c3d547/output/x86_64-w64-mingw32/bitcoin-dbb2d4c3d547-win64-debug.zip
27ede02f181ffe5209e4e2c6a11d8a460a380c49cd6478f5976594da5ec83a3fc3  guix-build-dbb2d4c3d547/output/x86_64-w64-mingw32/bitcoin-dbb2d4c3d547-win64-setup-unsigned.exe
2846c51d74cd46bd0ac3920a710e2d85314890d48d0ac258446bf5136309cadde3  guix-build-dbb2d4c3d547/output/x86_64-w64-mingw32/bitcoin-dbb2d4c3d547-win64-unsigned.zip

fanquake merged this on May 29, 2025

fanquake closed this on May 29, 2025

hebasto deleted the branch on May 29, 2025

build: Add resource file and manifest to bitcoin.exe #32634

Code Coverage & Benchmarks

Reviews

Testing

build: Add resource file and manifest to `bitcoin.exe` #32634