test: Prevent disk space warning during node_init_tests #33391

1. 
   ryanofsky commented at 1:55 pm on September 15, 2025: contributor

   mzumsande pointed out #32345 (comment) that this test was print a warning:

   0Warning: Disk space for "/tmp/test_common bitcoin/node_init_tests/init_test/bf78678cb7723a3e84b5/blocks" may not accommodate the block files. Approximately 810 GB of data will be stored in this directory.
   

   Fix by setting regtest instead of mainnet network before running the test.

2. test: Prevent disk space warning during node_init_tests

   mzumsande pointed out https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-3286964369 that this test was causing a warning:
   
      Warning: Disk space for "/tmp/test_common bitcoin/node_init_tests/init_test/bf78678cb7723a3e84b5/blocks" may not accommodate the block files. Approximately 810 GB of data will be stored in this directory.
   
   Fix by setting regtest instead of mainnet network before running the test.

   bdf01c6f61
3. DrahtBot added the label Tests on Sep 15, 2025
4. 
   DrahtBot commented at 1:55 pm on September 15, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33391.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	Eunovo, janb84, l0rinc, mzumsande, enirox001, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. fanquake added the label Needs backport (30.x) on Sep 15, 2025
6. fanquake added this to the milestone 30.0 on Sep 15, 2025
7. 
   Eunovo commented at 3:06 pm on September 15, 2025: contributor

   Tested ACK https://github.com/bitcoin/bitcoin/pull/33391/commits/bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f:

   The message does not appear when you build https://github.com/bitcoin/bitcoin/pull/33391/commits/bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f and run the unit tests, but it appears on master.

   Since the test is focused on initialisation and shutdown logic, the effect of using REGTEST chaintype here is minimal.

8. 
   janb84 commented at 6:39 pm on September 15, 2025: contributor

   ACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f

   Tested, warning does not appear anymore. ✅

   (Also had run into this problem on master, though it was related to my setup) Thanks for fixing this !

9. l0rinc approved
10. 
    l0rinc commented at 6:39 pm on September 15, 2025: contributor

    tested ACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f

    It prints the warning without the change, no warning after the change

11. 
    mzumsande commented at 7:06 pm on September 15, 2025: contributor

    utACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f
12. 
    enirox001 commented at 8:47 pm on September 15, 2025: contributor

    utACK bdf01c6
13. 
    achow101 commented at 1:11 am on September 16, 2025: member

    ACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f
14. achow101 merged this on Sep 16, 2025
15. achow101 closed this on Sep 16, 2025

    ---

16. fanquake referenced this in commit 3ae592537d on Sep 16, 2025
17. fanquake removed the label Needs backport (30.x) on Sep 16, 2025
18. 
    fanquake commented at 8:50 am on September 16, 2025: member

    Backported to 30.x in #33356.

Contributors
ryanofsky DrahtBot Eunovo janb84 l0rinc mzumsande enirox001 achow101 fanquake

Labels
Tests

Milestone
30.0