test: Prevent disk space warning during node_init_tests #33391

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/testwarn changing 1 files +6 −1
  1. ryanofsky commented at 1:55 PM on September 15, 2025: contributor

    mzumsande pointed out #32345 (comment) that this test was print a warning:

    Warning: Disk space for "/tmp/test_common bitcoin/node_init_tests/init_test/bf78678cb7723a3e84b5/blocks" may not accommodate the block files. Approximately 810 GB of data will be stored in this directory.
    

    Fix by setting regtest instead of mainnet network before running the test.

  2. test: Prevent disk space warning during node_init_tests
    mzumsande pointed out https://github.com/bitcoin/bitcoin/pull/32345#issuecomment-3286964369 that this test was causing a warning:
    
       Warning: Disk space for "/tmp/test_common bitcoin/node_init_tests/init_test/bf78678cb7723a3e84b5/blocks" may not accommodate the block files. Approximately 810 GB of data will be stored in this directory.
    
    Fix by setting regtest instead of mainnet network before running the test.
    bdf01c6f61
  3. DrahtBot added the label Tests on Sep 15, 2025
  4. DrahtBot commented at 1:55 PM on September 15, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33391.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK Eunovo, janb84, l0rinc, mzumsande, enirox001, achow101

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. fanquake added the label Needs backport (30.x) on Sep 15, 2025
  6. fanquake added this to the milestone 30.0 on Sep 15, 2025
  7. Eunovo commented at 3:06 PM on September 15, 2025: contributor

    Tested ACK https://github.com/bitcoin/bitcoin/pull/33391/commits/bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f:

    The message does not appear when you build https://github.com/bitcoin/bitcoin/pull/33391/commits/bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f and run the unit tests, but it appears on master.

    Since the test is focused on initialisation and shutdown logic, the effect of using REGTEST chaintype here is minimal.

  8. janb84 commented at 6:39 PM on September 15, 2025: contributor

    ACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f

    Tested, warning does not appear anymore. ✅

    (Also had run into this problem on master, though it was related to my setup) Thanks for fixing this !

  9. l0rinc approved
  10. l0rinc commented at 6:39 PM on September 15, 2025: contributor

    tested ACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f

    It prints the warning without the change, no warning after the change

  11. mzumsande commented at 7:06 PM on September 15, 2025: contributor

    utACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f

  12. enirox001 commented at 8:47 PM on September 15, 2025: contributor

    utACK bdf01c6

  13. achow101 commented at 1:11 AM on September 16, 2025: member

    ACK bdf01c6f61262cd6e211ead3c0dbc66ccb48b32f

  14. achow101 merged this on Sep 16, 2025
  15. achow101 closed this on Sep 16, 2025

  16. fanquake referenced this in commit 3ae592537d on Sep 16, 2025
  17. fanquake removed the label Needs backport (30.x) on Sep 16, 2025
  18. fanquake commented at 8:50 AM on September 16, 2025: member

    Backported to 30.x in #33356.

  19. glozow referenced this in commit b7a722724d on Sep 17, 2025
  20. sedited referenced this in commit 3f14dd4b2a on Oct 7, 2025
  21. sedited referenced this in commit 5f9d179b8d on Oct 8, 2025
  22. sedited referenced this in commit 845b93d99e on Oct 8, 2025
  23. yuvicc referenced this in commit ccce70c31a on Oct 8, 2025
  24. sedited referenced this in commit 3b1e26d5d3 on Oct 10, 2025
  25. sedited referenced this in commit 0fa2fdaca0 on Oct 11, 2025
  26. stringintech referenced this in commit f74b275ffc on Oct 14, 2025
  27. stickies-v referenced this in commit a785fe6759 on Nov 5, 2025
  28. morozow referenced this in commit 8247fddab1 on May 8, 2026
  29. morozow referenced this in commit 48f5d00b2b on May 8, 2026
  30. Kino1994 referenced this in commit dce035f7f5 on Jun 28, 2026
  31. BigcoinBGC referenced this in commit 40fbcfdee1 on Jun 30, 2026
  32. Kino1994 referenced this in commit f3369d1c79 on Aug 19, 2026
  33. bitcoin locked this on Sep 16, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-20 22:52 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me