ci: isolate container test networks #35417

pull willcl-ark wants to merge 2 commits into bitcoin:master from willcl-ark:container-networks changing 3 files +47 −8

willcl-ark commented at 7:54 PM on May 29, 2026: member

Fixes #35416

Local CI jobs currently share Docker networks while requesting fixed routable addresses. That prevents two jobs from running at the same time because the second container cannot claim the same static IPs. See 33362.

Name the networks "{container_name}-ipv[4|6]", using a subnet based on the hash of their name, so each CI job gets a separate network while the tests continue to see the addresses they expect.

Increment them to 11.x.x.x and 1111:2222:x to avoid hitting (existing) dangling networks on machines.

On successful runs, the networks are cleaned up. On failed runs they will remain (as they are being used by the failing container).

ci: isolate local test networks

Local CI jobs currently share Docker networks while requesting fixed
routable addresses. That prevents two jobs from running at the same time
because the second container cannot claim the same static IPs. See
33362.

Name the networks "{container_name}-ipv[4|6]", using a subnet based on
the hash of their name, so each CI job gets a separate network while the
tests continue to see the addresses they expect.

7af6acc1ea

ci: clean up local test networks

Previously the (single, shared) networks were left in docker after runs,
but with a network container this may get messy.

Remove the IPv4 and IPv6 networks when the run is successful. On a
failed run, networks will remain dangling and need manual pruning (same
behaviour as previously).

We can't remove networks automagically form failed runs without first
killing the container (docker doesn't let you remove networks which are
active), which we want to avoid so we can jump in to failures.

d23a74aa1b

DrahtBot added the label Tests on May 29, 2026
DrahtBot commented at 7:54 PM on May 29, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35417.



Reviews

See the guideline for information on the review process.

Type Reviewers

Concept ACK fanquake

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
willcl-ark commented at 7:56 PM on May 29, 2026: member

Implements one apprach from #35416 (comment)

I tried other ways of generating deterministic networks here (we have prcedent for using 'os.getpid()`), but I think in the end this is probably the most robust idea.

IMO cleaning up the networks is nicer, but I can drop that commit if it's not wanted for some reason unknown to me currently (or i can squash it).

Also open to other solutions here.
fanquake commented at 8:01 PM on May 29, 2026: member

Concept ACK - thanks for following up here.

Type	Reviewers
Concept ACK	fanquake

Contributors

Labels

Linked (view graph)

#35416 ci: side-effects from #33362

ci: isolate container test networks #35417

Code Coverage & Benchmarks

Reviews