Release cs_main before calling ProcessNewBlock, or processing headers (cmpctblock handling) #9252
pull sdaftuar wants to merge 2 commits into bitcoin:master from sdaftuar:cb-lock changing 1 files +22 −4-
sdaftuar commented at 6:57 pm on November 30, 2016: memberIf a compact block reconstructed successfully without any getblocktxn roundtrip, then we were calling ProcessNewBlock with cs_main held.
-
TheBlueMatt commented at 7:17 pm on November 30, 2016: memberArg. utACK 19d7db214da39765c048d1350ef368aedf858ca8
-
in src/main.cpp: in 19d7db214d outdated
5885@@ -5880,6 +5886,10 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv, 5886 return ProcessMessage(pfrom, NetMsgType::HEADERS, vHeadersMsg, nTimeReceived, chainparams, connman); 5887 } 5888 } 5889+ } // cs_main 5890+ 5891+ if (fBlockReconstructed) 5892+ return ProcessMessage(pfrom, NetMsgType::BLOCKTXN, blockTxnMsg, nTimeReceived, chainparams, connman);
ryanofsky commented at 7:22 pm on November 30, 2016:Looks like cs_main is still held during the ProcessMessage call above on line 5886. Maybe deserves a comment if this is intentional.
TheBlueMatt commented at 7:26 pm on November 30, 2016:Oh, actually this is not intentional, this is a separate bug.
sdaftuar commented at 3:42 pm on December 1, 2016:Added a commit that addresses this one as well.fanquake added the label Refactoring on Dec 1, 2016jonasschnelli added the label Needs backport on Dec 1, 2016sdaftuar renamed this:
Release cs_main before calling ProcessNewBlock (cmpctblock handling)
Release cs_main before calling ProcessNewBlock, or processing headers (cmpctblock handling)
on Dec 1, 2016TheBlueMatt commented at 10:08 pm on December 1, 2016: memberre-utACK 8c2e1c072a8c87b6fc1832e62f55e275284e7a3a (without backport)sipa removed the label Needs backport on Dec 1, 2016MarcoFalke commented at 2:53 pm on December 2, 2016: memberutACK, needs rebase.sdaftuar force-pushed on Dec 2, 2016morcos commented at 4:23 pm on December 2, 2016: memberutACK 0f1190fgmaxwell commented at 9:29 am on December 10, 2016: contributorstill needs rebase.sdaftuar force-pushed on Dec 11, 2016sdaftuar commented at 1:39 am on December 11, 2016: memberRebased.TheBlueMatt commented at 3:33 am on December 24, 2016: memberNeeds rebase again :/Release cs_main before calling ProcessNewBlock (cmpctblock handling) 680b0c0138Release cs_main before processing cmpctblock as header bd02bddb93sdaftuar force-pushed on Dec 26, 2016sdaftuar commented at 10:42 am on December 26, 2016: memberRebased.sipa commented at 6:25 pm on December 27, 2016: memberutACK bd02bddb938fa7ddf4e5dc7c3ce2a787feba848ainstagibbs commented at 5:04 pm on January 3, 2017: membermorcos commented at 8:27 pm on January 3, 2017: memberlightly tested reACK bd02bddsipa merged this on Jan 3, 2017sipa closed this on Jan 3, 2017
sipa referenced this in commit ce5c1f4aca on Jan 3, 2017gladcow referenced this in commit f29497c95f on Mar 5, 2018gladcow referenced this in commit 8ca015d698 on Mar 8, 2018gladcow referenced this in commit 05a6ea9cdb on Mar 13, 2018gladcow referenced this in commit 182106b938 on Mar 14, 2018gladcow referenced this in commit 6283f86906 on Mar 15, 2018gladcow referenced this in commit b4f02d36f5 on Mar 15, 2018gladcow referenced this in commit 42b554dbb1 on Mar 15, 2018gladcow referenced this in commit 38c9610cd2 on Mar 15, 2018gladcow referenced this in commit f732196dfc on Mar 24, 2018gladcow referenced this in commit 085e9ce46b on Apr 4, 2018UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me