[trivial] Fix typos in comments #9510

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:fix-typos-in-comments changing 21 files +24 −24
  1. practicalswift commented at 9:55 PM on January 10, 2017: contributor

    No description provided.

  2. in src/secp256k1/src/java/org/bitcoin/NativeSecp256k1.java:None in e12e618116 outdated
     358 | @@ -359,8 +359,8 @@ public static long cloneContext() {
     359 |      /**
     360 |       * libsecp256k1 create ECDH secret - constant time ECDH calculation
     361 |       *
     362 | -     * @param seckey byte array of secret key used in exponentiaion
     363 | -     * @param pubkey byte array of public key used in exponentiaion
     364 | +     * @param seckey byte array of secret key used in exponentiation
    


    paveljanik commented at 10:09 PM on January 10, 2017:

    Please report this upstream and remove it from here.

  3. in src/leveldb/util/env_win.cc:None in e12e618116 outdated
       0 | @@ -1,7 +1,7 @@
       1 |  // This file contains source that originates from:
       2 |  // http://code.google.com/p/leveldbwin/source/browse/trunk/win32_impl_src/env_win32.h
       3 |  // http://code.google.com/p/leveldbwin/source/browse/trunk/win32_impl_src/port_win32.cc
       4 | -// Those files dont' have any explict license headers but the 
       5 | +// Those files don't have any explicit license headers but the
    


    paveljanik commented at 10:10 PM on January 10, 2017:

    Please report this upstream and remove it from here.

  4. in src/leveldb/port/port_posix.h:None in e12e618116 outdated
      70 | @@ -71,7 +71,7 @@
      71 |  
      72 |  #if defined(OS_ANDROID) && __ANDROID_API__ < 9
      73 |  // fdatasync() was only introduced in API level 9 on Android. Use fsync()
      74 | -// when targetting older platforms.
      75 | +// when targeting older platforms.
    


    paveljanik commented at 10:10 PM on January 10, 2017:

    Please report this upstream and remove it from here.

  5. in build-aux/m4/ax_boost_base.m4:None in e12e618116 outdated
       9 | @@ -10,7 +10,7 @@
      10 |  #
      11 |  #   Test for the Boost C++ libraries of a particular version (or newer)
      12 |  #
      13 | -#   If no path to the installed boost library is given the macro searchs
      14 | +#   If no path to the installed boost library is given the macro searches
    


    paveljanik commented at 10:11 PM on January 10, 2017:

    Please report this upstream and remove it from here.

  6. paveljanik commented at 10:13 PM on January 10, 2017: contributor

    Good catches! Why do you have [gardening] in the commit message?

  7. in doc/Doxyfile:None in e12e618116 outdated
    1485 | @@ -1486,7 +1486,7 @@ EXT_LINKS_IN_WINDOW    = NO
    1486 |  
    1487 |  FORMULA_FONTSIZE       = 10
    1488 |  
    1489 | -# Use the FORMULA_TRANPARENT tag to determine whether or not the images
    1490 | +# Use the FORMULA_TRANSPARENT tag to determine whether or not the images
    


    paveljanik commented at 10:17 PM on January 10, 2017:

    Can you please report this typo also to doxygen (src/config.xml)?


    practicalswift commented at 10:23 PM on January 10, 2017:

    Sure! Will do!


    fanquake commented at 12:31 AM on January 11, 2017:

    I think this can just be sent upstream as well. It'll be pulled in if/when we regenerate the Doxyfile next.

  8. practicalswift force-pushed on Jan 10, 2017
  9. practicalswift commented at 10:23 PM on January 10, 2017: contributor

    @paveljanik Fixed and pushed!

    The [gardening] part is a long standing tradition from my contributions to the apple/swift repo :-) It simply means that the commit contains only hopefully non-controversial non-functional changes such as typo fixes, general cleanups, etc.

  10. paveljanik commented at 10:24 PM on January 10, 2017: contributor

    Concept ACK (will be read-ACK when you change/remove the [gardening]. We use 'trivial' here.

    I like gardening BTW - I prefer/collect magnolias ;-)

  11. practicalswift force-pushed on Jan 10, 2017
  12. practicalswift renamed this:
    [gardening] Fix typos in comments
    [trivial] Fix typos in comments
    on Jan 10, 2017
  13. practicalswift commented at 10:29 PM on January 10, 2017: contributor

    @paveljanik Fixed and pushed! :-)

    Thanks for the quick review! Two magnolia leafs for you: 🍃

  14. fanquake added the label Docs and Output on Jan 11, 2017
  15. fanquake commented at 12:31 AM on January 11, 2017: member

    utACK post nits being addressed.

  16. in src/tinyformat.h:None in 3e8f92c5bb outdated
     482 | @@ -483,7 +483,7 @@ namespace detail {
     483 |  
     484 |  // Type-opaque holder for an argument to format(), with associated actions on
     485 |  // the type held as explicit function pointers.  This allows FormatArg's for
     486 | -// each argument to be allocated as a homogenous array inside FormatList
     487 | +// each argument to be allocated as a homogeneous array inside FormatList
    


    MarcoFalke commented at 1:08 AM on January 11, 2017:

    tinyformat is from upstream as well

  17. practicalswift force-pushed on Jan 12, 2017
  18. practicalswift commented at 1:12 PM on January 12, 2017: contributor

    The changes to doc/Doxyfile and src/tinyformat.h are now excluded as per the suggestions from @fanquake and @MarcoFalke :-)

  19. fanquake commented at 1:14 PM on January 12, 2017: member

    ACK f2a4484

  20. in src/base58.h:None in f2a4484628 outdated
     146 | @@ -147,7 +147,7 @@ template<typename K, int Size, CChainParams::Base58Type Type> class CBitcoinExtK
     147 |      K GetKey() {
     148 |          K ret;
     149 |          if (vchData.size() == Size) {
     150 | -            //if base58 encouded data not holds a ext key, return a !IsValid() key
     151 | +            //if base58 encoded data not holds a ext key, return a !IsValid() key
    


    sipa commented at 1:15 PM on January 12, 2017:

    This still doesn't sound like english.


    fanquake commented at 1:17 PM on January 12, 2017:

    right. *data does not s/holds/hold


    practicalswift commented at 1:18 PM on January 12, 2017:

    Good point!

    I'm not familiar with this piece of the code - any suggestions on what the intention was here?

    Current wording (after typo fix):

    if base58 encoded data not holds a ext key, return a !IsValid() key

    My guess:

    If the base58 encoded data does not hold an ext key, return an !IsValid() key

    Could that be the correct guess? :-)

  21. in src/txmempool.h:None in f2a4484628 outdated
     339 | @@ -340,7 +340,7 @@ struct TxMempoolInfo
     340 |   * Transactions are added when they are seen on the network (or created by the
     341 |   * local node), but not all transactions seen are added to the pool. For
     342 |   * example, the following new transactions will not be added to the mempool:
     343 | - * - a transaction which doesn't make the mimimum fee requirements.
     344 | + * - a transaction which doesn't make the minimum fee requirements.
    


    sipa commented at 1:18 PM on January 12, 2017:

    doesn't meet?


    practicalswift commented at 1:20 PM on January 12, 2017:

    Fixed and pushed! :-)

  22. practicalswift force-pushed on Jan 12, 2017
  23. practicalswift commented at 10:43 AM on January 18, 2017: contributor

    @sipa & @fanquake Do you have input on the outstanding question on how to interpret the line if base58 encoded data?

    Let me know if that change needs more time for review - if so I can simply open a separate PR for that one to allow this one to be merged with the approved changes only :-)

  24. fanquake commented at 11:17 AM on January 18, 2017: member

    @practicalswift See my comment inline: #9510 (review), your interpretation looks correct. A second PR is definitely not needed here, please incorporate the comment changes.

  25. practicalswift force-pushed on Jan 18, 2017
  26. practicalswift commented at 3:16 PM on January 18, 2017: contributor

    @fanquake Fixed! Everything OK now? :-)

  27. practicalswift force-pushed on Jan 18, 2017
  28. [trivial] Fix typos in comments cc16d99f1d
  29. practicalswift force-pushed on Jan 27, 2017
  30. practicalswift commented at 8:23 PM on January 27, 2017: contributor

    Merge conflict resolved. This one should be ready for merge AFAIK :-)

  31. MarcoFalke commented at 3:04 PM on January 29, 2017: member

    utACK cc16d99f1dc8305b1b255f1cc0f2b1516aa77

  32. MarcoFalke merged this on Jan 29, 2017
  33. MarcoFalke closed this on Jan 29, 2017

  34. MarcoFalke referenced this in commit 0fea960ca9 on Jan 29, 2017
  35. practicalswift commented at 5:10 PM on January 29, 2017: contributor

    @MarcoFalke Thanks for merging! Another round of typo fixes in PR #9651 :-)

  36. in src/init.cpp:None in cc16d99f1d
    1552 | @@ -1553,7 +1553,7 @@ bool AppInitMain(boost::thread_group& threadGroup, CScheduler& scheduler)
    1553 |      }
    1554 |  
    1555 |      if (chainparams.GetConsensus().vDeployments[Consensus::DEPLOYMENT_SEGWIT].nTimeout != 0) {
    1556 | -        // Only advertize witness capabilities if they have a reasonable start time.
    


    rebroad commented at 9:27 AM on February 1, 2017:

    this probably was not a typo. it's how it's spelled in some countries.


    practicalswift commented at 10:35 AM on February 1, 2017:

    @rebroad Do you know in what countries? As I've understood it "advertise" is the form used in both US and UK, but there are more English speaking countries than that obviously :-)


    rebroad commented at 5:29 AM on February 2, 2017:

    @practicalswift I apologise, you are correct!

  37. codablock referenced this in commit b1a48224a6 on Jan 19, 2018
  38. codablock referenced this in commit 2884c775b6 on Jan 20, 2018
  39. codablock referenced this in commit 660c027cd5 on Jan 21, 2018
  40. gladcow referenced this in commit b1efc962cd on Mar 8, 2018
  41. gladcow referenced this in commit 2e01837bcd on Mar 13, 2018
  42. gladcow referenced this in commit 0c9b5db6fa on Mar 14, 2018
  43. gladcow referenced this in commit 1eb4016b23 on Mar 15, 2018
  44. gladcow referenced this in commit ac0567034c on Mar 15, 2018
  45. gladcow referenced this in commit 64b3edb4cf on Mar 15, 2018
  46. gladcow referenced this in commit bd58e054af on Mar 15, 2018
  47. gladcow referenced this in commit 8f5b088b2f on Mar 24, 2018
  48. gladcow referenced this in commit 8e04e55bab on Apr 4, 2018
  49. UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
  50. andvgal referenced this in commit 403cfb71e4 on Jan 6, 2019
  51. andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
  52. CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
  53. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me