Remove contrib/debian/patches subdirectory #9699

pull droark wants to merge 1 commits into bitcoin:master from droark:removedebpatches changing 2 files +0 −4

droark commented at 8:25 PM on February 6, 2017: contributor

The directory hasn’t been touched in five years and seems like something that could be added again later if needed. Remove the subdirectory.

Remove contrib/debian/patches subdirectory

The directory hasn’t been touched in five years and seems like something that could be added again later if needed. Remove the subdirectory.

ca04070724

practicalswift commented at 10:29 PM on February 6, 2017: contributor

utACK ca04070
TheBlueMatt commented at 11:30 PM on February 6, 2017: member
Have you tested if the Debian build still succeeds if these files are missing? I'd bet they don't.

On February 6, 2017 3:25:48 PM EST, Douglas Roark notifications@github.com wrote:
The directory hasn’t been touched in five years and seems like something that could be added again later if needed. Remove the subdirectory. You can view, comment on, or merge this pull request online at:

#9699

-- Commit Summary --

Remove contrib/debian/patches subdirectory

-- File Changes --

D contrib/debian/patches/README (3) D contrib/debian/patches/series (1)

-- Patch Links --

https://github.com/bitcoin/bitcoin/pull/9699.patch https://github.com/bitcoin/bitcoin/pull/9699.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/9699
laanwj commented at 9:53 AM on February 7, 2017: member

What I sometimes wonder: is anyone using the stuff in contrib/debian to do debian builds at all? Is it used for the PPAs?
TheBlueMatt commented at 12:36 PM on February 7, 2017: member

It is (roughly) used for the PPAs, AFAIK that is the only user.

On February 7, 2017 4:53:13 AM EST, "Wladimir J. van der Laan" notifications@github.com wrote:

What I sometimes wonder: is anyone using the stuff in contrib/debian to do debian builds at all? Is it used for the PPAs?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/9699#issuecomment-277951034
laanwj commented at 1:10 PM on February 7, 2017: member

Okay, thanks. Yes that's enough reason to keep it around.
TheBlueMatt commented at 1:32 PM on February 7, 2017: member

Yea, I would say trash it, but we've gotten contributors to update the PPA through it, which helps me be super lazy :).

On February 7, 2017 8:10:53 AM EST, "Wladimir J. van der Laan" notifications@github.com wrote:

Okay, thanks. Yes that's enough reason to keep it around.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/9699#issuecomment-277995092
fanquake commented at 3:52 PM on February 7, 2017: member

Closing, seems we want to keep this.
fanquake closed this on Feb 7, 2017
laanwj commented at 4:56 PM on February 7, 2017: member

Well, yes, this directory (and the accompanying README file) is a standard fixture in contrib/debian directories, it doesn't hurt to keep it around, though it's unlikely any patches will be added there as we could just as well patch the project itself as it's part of the same tree.
droark commented at 7:08 AM on February 8, 2017: contributor

Thanks, everyone. I'll add a PR a little later that updates the README. Might as well ensure that people know to leave the directory alone. :)
droark deleted the branch on Mar 17, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors