Add test to ensure map serialization is working and will keep working. Useful for #285.
Also removes mapSize on capnp since pass will already exercise it, and renames v_bool to vector_bool.
Best reviewed commit by commit.
test: add map serialization round-trip coverage #297
pull ViniciusCestarii wants to merge 3 commits into bitcoin-core:master from ViniciusCestarii:test-type-map changing 3 files +22 −14-
ViniciusCestarii commented at 6:35 PM on June 11, 2026: contributor
-
DrahtBot commented at 6:35 PM on June 11, 2026: none
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK xyzconstant Concept ACK w0xlt If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #288 (Create
supportbranch for CI scripts, documentation, and examples by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- #288 (Create
-
test: add mapStringInt to foo.capnp to cover map serialization and deserialization 85df233845
-
test: drop mapSize, now covered by map round-trip test 490585f044
-
test: rename vBool to vector_bool 645d90b546
- ViniciusCestarii force-pushed on Jun 11, 2026
-
ViniciusCestarii commented at 6:44 PM on June 11, 2026: contributor
Forced-push 645d90b to include map on test.cpp for IWYU
-
w0xlt commented at 12:41 AM on June 12, 2026: none
Concept ACK
-
xyzconstant commented at 6:57 PM on June 18, 2026: contributor
Looks clean to me, tACK 645d90b5461fcca540df781859ee8e8c06cb514a
Contributors
Linked (view graph)