[29.x] Backports #32292

1. 
   fanquake commented at 10:55 am on April 17, 2025: member

   Backports for 29.x:

   • #32184
   • #32187
   • #32248
   • #32286
2. 
   DrahtBot commented at 10:55 am on April 17, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32292.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

3. DrahtBot added the label Backport on Apr 17, 2025
4. 
   maflcko commented at 10:59 am on April 17, 2025: member

   Could also add #32184 ?
5. maflcko added the label DrahtBot Guix build requested on Apr 17, 2025
6. maflcko added this to the milestone 29.1 on Apr 17, 2025
7. Remove support for RNDR/RNDRRS for aarch64 on Linux

   This hardware feature is
   
   - rarely supported on SoCs (and broken on like half of the chips that support it in the first place) (#31817)
   - apparently not compiled into the release binary (https://github.com/bitcoin/bitcoin/issues/31817#issuecomment-2795885962)
   - hard to test in CI, due to unavailable of hardware
   
   Better to remove it.
   
   This reverts commit aee5404e02e203a256c1a97b629b9b107cc8bb07.
   
   Closes #31817.
   
   Github-Pull: #32248
   Rebased-From: 7749d929a0d9dfe71541a22e557ea41e01df28ce

   1393ad4308
8. test: Handle empty string returned by CLI as None in RPC tests

   Github-Pull: #32286
   Rebased-From: a4041c77f0e20d004524868e70ff12508832c9eb

   8b25ce59be
9. fanquake force-pushed on Apr 17, 2025
10. ci: Add workaround for vcpkg's libevent package

    This change is necessary for Windows GHA images, which provide
    CMake >= 4.0.
    
    Github-Pull: #32184
    Rebased-From: ef00a28414daed2dd026b458082ed03fe9508074

    c01ac36b30
11. in .github/workflows/ci.yml:202 in 57254e7541 outdated

    197@@ -198,6 +198,8 @@ jobs:
    198           Set-Location "$env:VCPKG_INSTALLATION_ROOT"
    199           Add-Content -Path "triplets\x64-windows.cmake" -Value "set(VCPKG_BUILD_TYPE release)"
    200           Add-Content -Path "triplets\x64-windows-static.cmake" -Value "set(VCPKG_BUILD_TYPE release)"
    201+          # Workaround for libevent, which requires CMake 3.1 but is incompatible with CMake >= 4.0.
    202+          sed -i '1s/^/set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5)\n/' "${VCPKG_INSTALLATION_ROOT}/scripts/ports.cmake"
    

    ---

    ---

    

    hebasto commented at 1:49 pm on April 17, 2025:

    bash has to be used to run sed:

     0--- a/.github/workflows/ci.yml
     1+++ b/.github/workflows/ci.yml
     2@@ -194,10 +194,10 @@ jobs:
     3           Write-Host "PowerShell version $($PSVersionTable.PSVersion.ToString())"
     4 
     5       - name: Using vcpkg with MSBuild
     6+        shell: bash
     7         run: |
     8-          Set-Location "$env:VCPKG_INSTALLATION_ROOT"
     9-          Add-Content -Path "triplets\x64-windows.cmake" -Value "set(VCPKG_BUILD_TYPE release)"
    10-          Add-Content -Path "triplets\x64-windows-static.cmake" -Value "set(VCPKG_BUILD_TYPE release)"
    11+          echo "set(VCPKG_BUILD_TYPE release)" >> "${VCPKG_INSTALLATION_ROOT}/triplets/x64-windows.cmake"
    12+          echo "set(VCPKG_BUILD_TYPE release)" >> "${VCPKG_INSTALLATION_ROOT}/triplets/x64-windows-static.cmake"
    13           # Workaround for libevent, which requires CMake 3.1 but is incompatible with CMake >= 4.0.
    14           sed -i '1s/^/set(ENV{CMAKE_POLICY_VERSION_MINIMUM} 3.5)\n/' "${VCPKG_INSTALLATION_ROOT}/scripts/ports.cmake"
    

    See: f8619196ceb5c6a58125506d276d9515837f043a

12. fanquake force-pushed on Apr 17, 2025
13. refactor: Remove spurious virtual from final ~CZMQNotificationInterface

    Github-Pull: #32187
    Rebased-From: fa69c42fdf0aeec0546e951bc6132ab630edb9d4

    f1d1b85efa
14. doc: update release notes for 29.x ae2a3fd815
15. fanquake force-pushed on Apr 17, 2025

Contributors
fanquake DrahtBot maflcko hebasto

Labels
Backport DrahtBot Guix build requested

Milestone
29.1