Github-Pull: #32551
Rebased-From: 800b7cc42ca63f2a6b245a4d327c7092289da6e1
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32589.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | instagibbs, willcl-ark |
| Stale ACK | glozow, theuni |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Possible typos and grammar issues:
drahtbot_id_4_m
See https://guix.gnu.org/blog/2025/migrating-to-codeberg/.
When interacting with the old repo you may now also see:
```bash
warning: redirecting to https://codeberg.org/guix/guix/
```
Github-Pull: #32439
Rebased-From: c8d9baae942c94d64ce47ae8f67d3710e6a296bd
Previously, the `pruneblockchain` RPC help output included only the method signature and arguments, with no top-level description explaining its purpose or constraints.
This PR adds a concise top-level description, improving documentation consistency and alerting users to the potential impacts of using the command.
Github-Pull: #32333
Rebased-From: 135a0f0aa711b95c50aa4cbe0c38d82d647f1c8b
It currently only syncs between the first two nodes,
which may do nothing when the block is created on the
third node.
Github-Pull: #32630
Rebased-From: 4df4df45d7bc2e8be99325d40cda936aab87c083
It looks like the mkdir detection in xproto is broken on Alpine. Ensure
we always use `mkdir -p`.
Fixes #32494.
Github-Pull: #32568
Rebased-From: df9ebbf659d5d1282289f36d7f9ee7103aa33a17
Github-Pull: #32679
Rebased-From: 4ce53495e5e18370b7935551b3b8700faa720a33
Github-Pull: #32607
Rebased-From: f98e1aaf34e347088caa54403521e3b5cb55dd40
This RPC lists all the descriptors present in the wallet, not only
the ones that were imported, but also the ones generated when a
new wallet is created.
It can be verified by creating a new wallet and calling the
`listdescriptors` RPC, which will contain 8 ranged descriptors that
are created for every new wallet.
Github-Pull: #32708
Rebased-From: b44514b876333a94ae242da8b1e4cee439c2d37e
Github-Pull: #32711
Rebased-From: 89526deddf87904619b26319e8d149cf97466868
Current behaviour will by-default use SOURCE_DATE_EPOCH from the
environment without warning. This breaks the default reproducibility
from a guix build.
Warn when and exit when this variable is set, and
FORCE_SOURCE_DATE_EPOCH is unset.
Github-Pull: #32678
Rebased-From: 5c4a0f8009cef758be9412428515bfed57b0c923
Github-Pull: #32696
Rebased-From: 32d4e92b9ac81858d754487bfec2fef6bed13a57
@achow101 is that ok to backport? See #32625 (comment)
Yes. https://github.com/bitcoin-core/gui/pull/864 is a fix for the root cause of some unclean shutdowns, it’s otherwise unrelated to #31757.
57@@ -57,6 +58,11 @@ Notable changes
58 - #32356 cmake: Respect user-provided configuration-specific flags
59 - #32437 crypto: disable ASan for sha256_sse4 with Clang
60 - #32469 cmake: Allow WITH_DBUS on all Unix-like systems
61+- #32439 guix: accomodate migration to codeberg
62+- #32551 cmake: Add missed SSE41_CXXFLAGS
1780@@ -1781,7 +1781,7 @@ RPCHelpMan listdescriptors()
1781 {
1782 return RPCHelpMan{
1783 "listdescriptors",
1784- "\nList descriptors imported into a descriptor-enabled wallet.\n",
1785+ "\nList all descriptors present in a descriptor-enabled wallet.\n",
lightly tested ACK b1ca5b7c623258bd29eca8447006d26aefb8686f
Did the same backports, the conflict resolutions look correct to me. Release notes look correct. It would be great if someone could do the OpenBSD multiprocess build, as I did not test that.
utACK b1ca5b7c623258bd29eca8447006d26aefb8686f
Backported the commits referenced in the descriptions and ended up with the same results after fixing merge conflicts.
Only conflict I didn’t agree with 100% was capnproto, which conflicted because we had an extra patch in master, then dropped it in favor of a version bump. See comment above about potentially taking one of those PRs.
On OpenBSD, the `sha256` command by default outputs hashsums on files in
"BSD" mode, looking like this:
$ sha256 ~/.vimrc
SHA256 (/home/thestack/.vimrc) = 6ba69d100e8c5ca0488ded6293d4e5f740a6a5d5ace96cbcf0599c18d27389e4
This is not compatible with our depends commands, which expect the
hashes to be on the first column (to be extracted via `cut -d" " -f1`).
Fix this by switching to GNU mode output, looking like this:
$ sha256 -r ~/.vimrc
6ba69d100e8c5ca0488ded6293d4e5f740a6a5d5ace96cbcf0599c18d27389e4 /home/thestack/.vimrc
Without this change, the multiprocess depends build fails with the following output:
$ gmake -C depends MULTIPROCESS=1 NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_QR=1 NO_WALLET=1 NO_ZMQ=1 NO_USDT=1
[ ..... ]
Extracting native_libmultiprocess...
sha256: /home/thestack/bitcoin/depends/work/build/x86_64-unknown-openbsd7.7/native_libmultiprocess/-2bc902f4693/.src-ipc-libmultiprocess.tar.hash: no properly formatted checksum lines found
gmake: *** [funcs.mk:342: /home/thestack/bitcoin/depends/work/build/x86_64-unknown-openbsd7.7/native_libmultiprocess/-2bc902f4693/.stamp_extracted] Error 1
Github-Pull: #32690
Rebased-From: 8713e8060d504f561fed705b4aa5af7b96c36e75
Matches /share/setup.nsi.in:14
Github-Pull: #32719
Rebased-From: 239fc4d62e73511b3ef5117706d4c5131a921955
Patch cmake_minimum_required version for freetype, using the version from
https://gitlab.freedesktop.org/freetype/freetype/-/merge_requests/352/diffs
This fixes a failure when building with CMake 4, where compatibility
with CMake versions < 3.5 has been removed (see https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features)
Github-Pull: #32693
Rebased-From: d7c37906e7b1dc1513439056d0cdb2bd341d00f1
The wallet crashes if it processes the same block disconnection event twice in a row due
to an incompatible coinbase transaction state.
This happens because 'disconnectBlock' provides 'TxStateInactive' without the "abandoned"
flag for coinbase transactions to 'SyncTransaction', while 'AddToWallet()' internally
modifies it to retain the abandoned state.
The flow is as follows:
1) On the first disconnection, the transaction state transitions from "confirmed" to
"inactive," bypassing the state equality check since the provided state differs. Then,
'AddToWallet' internally updates the state to "inactive + abandoned"
2) On the second disconnection, as we provide only the "inactive" state
to 'SyncTransaction()', the state equality assertion fails and crashes the wallet.
Github-Pull: #31757
Rebased-From: 9ef429b6ae65f6ad3e9ac11c2d9c0a6c52beb865
Co-authored-by: furszy <matiasfurszyfer@protonmail.com>
Github-Pull: #31757
Rebased-From: 11f8ab140fe63857f6a93b81021efda8f90ceeda
Github-Pull: #32760
Rebased-From: c7eaac326ac20a745d1bc6dbc6bc48c1b5eb46f8
Github-Pull: #32776
Rebased-From: 8ee8a951c205c5365f7557253b8fffc12e6e670c
Github-Pull: #32777
Rebased-From: 53a996f122663e271efa52c45b173613b8ac635e
Github-Pull: #32765
Rebased-From: e285e691b7a311e278f89e9fe423716de1ee268b
Github-Pull: #32771
Rebased-From: 3473986fe10e2689fe36cc93e1e50013649ac14b
ACK 0922f6bbc33ac2abe3f3d9dc98dade896718864f
Checked all backports are clean and match their parent commits. All backports which include a Github-Pull: #xxxxx line in the commit message are mentioned in release-notes.md.