Convert check-deps.sh to python #35167

ajtowns commented at 3:12 PM on April 27, 2026: contributor

Converts check-deps.sh to python so that it can use the mermaid graph from doc/design/libraries.md as its source of truth, as well as automatically resolve transitive dependencies and demangle C++ names.

doc: Update library dependencies 8a74832314

DrahtBot commented at 3:12 PM on April 27, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	sedited
Concept ACK	janb84, BrandonOdiwuor

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#32427 ((RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store by sedited)
#30437 (ipc: add bitcoin-mine test program by ryanofsky)
#28690 (build: Introduce internal kernel library by sedited)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ajtowns commented at 3:15 PM on April 27, 2026: contributor

Not sure if we want to remove all the transitive deps from the md file, but without them it's a fair bit easier to follow, at least compared to master:

%%{ init : { "flowchart" : { "curve" : "basis" }}}%%

graph TD;

bitcoin-cli[bitcoin-cli]-->libbitcoin_cli;

bitcoind[bitcoind]-->libbitcoin_node;
bitcoind[bitcoind]-->libbitcoin_wallet;

bitcoin-qt[bitcoin-qt]-->libbitcoinqt;

bitcoin-wallet[bitcoin-wallet]-->libbitcoin_wallet;

libbitcoin_cli-->libbitcoin_util;

libbitcoin_consensus-->libbitcoin_util;

libbitcoin_common-->libbitcoin_consensus;

libbitcoin_kernel-->libbitcoin_consensus;

libbitcoin_node-->libbitcoin_kernel;
libbitcoin_node-->libbitcoin_common;

libbitcoinqt-->libbitcoin_cli;
libbitcoinqt-->libbitcoin_node;
libbitcoinqt-->libbitcoin_wallet;

libbitcoin_util-->libbitcoin_crypto;

libbitcoin_wallet-->libbitcoin_common;

classDef bold stroke-width:2px, font-weight:bold, font-size: smaller;
class bitcoin-qt,bitcoind,bitcoin-cli,bitcoin-wallet bold

sedited commented at 8:47 PM on April 27, 2026: contributor

Nice, Concept ACK

Not sure if we want to remove all the transitive deps from the md file, but without them it's a fair bit easier to follow, at least compared to master:

I feel like this was brought up before - makes it indeed much cleaner.

in doc/design/libraries.md:74 in 24b0d4c049

janb84 commented at 9:52 AM on April 28, 2026:

**Dependency graph**. Arrows show permitted linker symbol dependencies; the maximum each library is allowed to reference. Actual usage is a subset; the linker enforces nothing automatically. A permitted edge may be unexercised, which is not a bug and can be removed from the graph once verified. *Crypto* lib depends on nothing. *Util* lib is depended on by everything. *Kernel* lib depends only on consensus, crypto, and util.

NIT: For me it was not clear that the depicted Dependency graph is more a "allow list" than an actual state of dependency usage. If you know you will read this distinction in the rest of the document but I think it would help to be a bit more clear for the casual reader / first time bitcoin dev-er. Text is nothing more than a suggestion.

sedited commented at 2:24 PM on April 28, 2026: contributor

It's really nice to actually be able to read this now.

Re the additional warning we get now:

Declared dependencies with no symbol references:
  bitcoin_cli -> bitcoin_util

libbitcoin_cli really doesn't seem to require libbitcoin_util, so maybe we can add an edge for bitcoin-cli->libbitcoin_util and remove the existing libbitcoin_cli->libbitcoin_util edge? Could also use this opportunity to cleanup the common/args.h include from rpc/client.cpp.

ACK 24b0d4c0496b1d4c1986269e11b9bb2a23c67f2e

in contrib/devtools/check-deps.py:86 in 24b0d4c049

  81 | +        parts = line.split()
  82 | +        if len(parts) < 3:
  83 | +            continue
  84 | +        loc = parts[0]  # lib:obj:addr or lib:obj:
  85 | +        sym_type = parts[1]
  86 | +        symbol = parts[2]

janb84 commented at 2:25 PM on April 28, 2026:

        loc = parts[0]
        sym_type = parts[-2]
        symbol = parts[-1]

NIT: there is a slight behavioral difference between nm on linux and on mac:

linux nm: "lib.a:obj.o:<addr> <type> <symbol>" (addr glued to obj:, blank for undefined) Apple nm: "lib.a:obj.o: <addr> <type> <symbol>" (space after obj:, addr always its own token) Both, the last two whitespace tokens are <type> <symbol>, NIT is to use that.

nm linux:

 nm -o -g build_dev_mode/lib/libbitcoin_util.a 2>/dev/null | head -8
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                 U __assert_fail
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                 U __cxa_allocate_exception
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                 U __cxa_begin_catch
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                 U __cxa_end_catch
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                 U __cxa_free_exception
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                 U __cxa_throw
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:0000000000000000 V DW.ref.__gxx_personality_v0
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:0000000000000000 V DW.ref._ZTIN10tinyformat12format_errorE

nm macos:

nm -o -g build_dev_mode/lib/libbitcoin_util.a 2>/dev/null | head -8
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                  U __Unwind_Resume
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o: 00000000000012fc T __Z11DecodeAsmapN2fs4pathE
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                  U __Z11GetMockTimev
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o: 0000000000001d08 T __Z12AsmapVersionNSt3__14spanIKSt4byteLm18446744073709551615EEE
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o:                  U __Z14SysErrorStringi
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o: 0000000000000994 T __Z16SanityCheckAsmapNSt3__14spanIKSt4byteLm18446744073709551615EEEi
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o: 0000000000000f48 T __Z18CheckStandardAsmapNSt3__14spanIKSt4byteLm18446744073709551615EEE
build_dev_mode/lib/libbitcoin_util.a:asmap.cpp.o: 0000000000000ffc T __Z22LogPrintFormatInternalIJEEvO14SourceLocationN5BCLog8LogFlagsEN4util3log5LevelEbNS4_21ConstevalFormatStringIXsZT_EEEDpRKT_

</details>

script to check behavior:

python3 -c "
import sys
sys.path.insert(0, 'contrib/devtools')
import importlib.util
spec = importlib.util.spec_from_file_location('cd', 'contrib/devtools/check-deps.py')
m = importlib.util.module_from_spec(spec); spec.loader.exec_module(m)
defined, undefined = m.get_symbols_per_obj('build_dev_mode/lib/libbitcoin_util.a')
print('defined symbols  :', sum(len(v) for v in defined.values()))
print('undefined symbols:', sum(len(v) for v in undefined.values()))
print('sample defined  :', sorted(next(iter(defined.values())))[:2])
"

on macos, before:

defined symbols captured : 0
undefined symbols captured: 1104

After:

defined symbols  : 902
undefined symbols: 1104

</details>

ajtowns commented at 12:27 AM on April 29, 2026:

It would have also failed on macos with the shell script, right?

ajtowns commented at 12:31 AM on April 29, 2026:

Switched to a regex that should also work on macos

janb84 commented at 7:46 PM on April 29, 2026:

It would have also failed on macos with the shell script, right?

Yes, well even worse it would give a "false" succes report.

janb84 commented at 2:31 PM on April 28, 2026: contributor

Concept ACK 24b0d4c0496b1d4c1986269e11b9bb2a23c67f2e

Brings the script more in line with the programming language used for the other tools.

Found some small Nits.

hebasto commented at 4:29 PM on April 28, 2026: member

... it can use the mermaid graph from doc/design/libraries.md as its source of truth...

I have always considered doc/design/libraries.md to be a design goal rather than a current reality.

I don't think it can be considered the "source of truth" at this stage of development. For example, bitcoind.cpp directly uses symbols from bitcoin_common (such as ArgsManager::GetBoolArg), and bitcoin_common headers are build requirements for the bitcoind target. This relationship isn't reflected in doc/design/libraries.md and is currently out of scope for the check-deps script, which might cause confusion.

cc @purpleKarrot

ci: Convert check-deps to python and use design doc dependencies directly 5d3c53858e

refactor: Move init/common.cpp to libbitcoin_node

These init functions are only used by node implementations, so the
special case in dep-check can be removed.

9399bf309a

doc: Drop transitive lib dependencies and lib wallet-tool 3c0e2f544e

ajtowns commented at 12:30 AM on April 29, 2026: contributor

I don't think it can be considered the "source of truth" at this stage of development. For example, bitcoind.cpp directly uses symbols from bitcoin_common (such as ArgsManager::GetBoolArg), and bitcoin_common headers are build requirements for the bitcoind target. This relationship isn't reflected in doc/design/libraries.md and is currently out of scope for the check-deps script, which might cause confusion.

Neither the shell or python check-deps script check binary dependencies -- binaries without all their deps will just fail to run anyway, so there's not much point. Even if they were checked, the transitive resolution in the python script would cover this case -- bitcoind depends on libbitcoin_node which depends on libbitcoin_common. (bitcoind would still need to explicitly link to libbitcoin_common presuming libbitcoin_node doesn't publicly incorporate libbitcoin_common though)

ajtowns force-pushed on Apr 29, 2026

in contrib/devtools/check-deps.py:150 in 3c0e2f544e

 145 | +            sys.exit(f"Error: build directory {build_dir} not found")
 146 | +        not_buildable = []
 147 | +        for target in declared_deps:
 148 | +            result = subprocess.run(
 149 | +                ["cmake", "--build", str(build_dir), "-j", str(os.cpu_count()), "-t", target],
 150 | +                capture_output=True, text=True

janb84 commented at 7:57 PM on April 29, 2026:

Not sure about suppressing build output, this deviates from the shell script variant and it somewhat confusing that "nothing" happens in default mode. (but it's building in the background)

janb84 commented at 7:57 PM on April 29, 2026: contributor

Concept ACK 3c0e2f544ecc9097661baaac0ade1a4ea6ad6506

Big improvement for MacOs usage, it will no-longer report a false succes :

Master:

Warning: suppression 'common.cpp.o interface_ui.cpp.o _Z9InitErrorRK13bilingual_str' was ignored, consider deleting.
Warning: suppression 'common.cpp.o interface_ui.cpp.o _Z11InitWarningRK13bilingual_str' was ignored, consider deleting.
Success! No unexpected dependencies were detected.

New Python based script (--no-build to reuse master build):

./contrib/devtools/check-deps.py --no-build
Warning: libraries not found: bitcoin_kernel, bitcoinqt
Error: bitcoin_common -> bitcoin_node (2 symbols)
  common.cpp.o -> interface_ui.cpp.o: InitWarning(bilingual_str const&)
  common.cpp.o -> interface_ui.cpp.o: InitError(bilingual_str const&)

(use --show-suppressions to see suppress directives)

2 unexpected dependencies found.

BrandonOdiwuor commented at 10:00 AM on April 30, 2026: contributor

Concept ACK 3c0e2f544ecc9097661baaac0ade1a4ea6ad6506 moving the ./contrib/devtools/check-deps.sh to Python

The previous check-deps.sh was transparent about triggering a rebuild, while the new check-deps.py builds silently in the background with no feedback, which feels confusing

Master (before PR)

<details> <summary>Running `./contrib/devtools/check-deps.sh` </summary>

git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
brandon-odiwuor@brandon-odiwuor-ubuntu:~/bitcoin/bitcoin$ ./contrib/devtools/check-deps.sh build_dev_mode/
-- Could NOT find XKB (missing: XKB_LIBRARY XKB_INCLUDE_DIR) (Required is at least version "0.5.0")
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE dot) 

Configuring secp256k1 subtree...
-- Could NOT find Valgrind (missing: Valgrind_INCLUDE_DIR Valgrind_WORKS) 


secp256k1 configure summary
===========================
Build artifacts:
  library type ........................ Static
Optional modules:
  ECDH ................................ OFF
  ECDSA pubkey recovery ............... ON
  extrakeys ........................... ON
  schnorrsig .......................... ON
  musig ............................... ON
  ElligatorSwift ...................... ON
Parameters:
  ecmult window size .................. 15
  ecmult gen table size ............... 86 KiB
Optional features:
  assembly ............................ x86_64
  external callbacks .................. OFF
Optional binaries:
  benchmark ........................... OFF
  noverify_tests ...................... ON
  tests ............................... ON
  exhaustive tests .................... ON
  ctime_tests ......................... OFF
  examples ............................ OFF

Cross compiling ....................... FALSE
API visibility attributes ............. OFF
Valgrind .............................. OFF
Preprocessor defined macros ........... ECMULT_WINDOW_SIZE=15 COMB_BLOCKS=43 COMB_TEETH=6 USE_ASM_X86_64=1
C compiler ............................ GNU 13.3.0, /usr/bin/cc
CFLAGS ................................ 
Compile options ....................... -Wall -pedantic -Wcast-align -Wcast-align=strict -Wextra -Wnested-externs -Wno-long-long -Wno-overlength-strings -Wno-unused-function -Wshadow -Wstrict-prototypes -Wundef
Build type:
 - CMAKE_BUILD_TYPE ................... RelWithDebInfo
 - CFLAGS ............................. -O2 -g 
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 



Configure summary
=================
Executables:
  bitcoin ............................. ON
  bitcoind ............................ ON
  bitcoin-node (multiprocess) ......... ON
  bitcoin-qt (GUI) .................... ON
  bitcoin-gui (GUI, multiprocess) ..... ON
  bitcoin-cli ......................... ON
  bitcoin-tx .......................... ON
  bitcoin-util ........................ ON
  bitcoin-wallet ...................... ON
  bitcoin-chainstate (experimental) ... ON
  libbitcoinkernel (experimental) ..... ON
  kernel-test (experimental) .......... ON
Optional features:
  wallet support ...................... ON
  external signer ..................... ON
  ZeroMQ .............................. ON
  IPC ................................. ON
  Embedded ASMap ...................... ON
  USDT tracing ........................ ON
  QR code (GUI) ....................... ON
  DBus (GUI) .......................... ON
Tests:
  test_bitcoin ........................ ON
  test_bitcoin-qt ..................... ON
  bench_bitcoin ....................... ON
  fuzz binary ......................... ON

Cross compiling ....................... FALSE
C++ compiler .......................... GNU 13.3.0, /usr/bin/c++
CMAKE_BUILD_TYPE ...................... RelWithDebInfo
Preprocessor defined macros ........... 
C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fno-extended-identifiers -fmacro-prefix-map=/home/brandon-odiwuor/bitcoin/bitcoin/src=. -fstack-reuse=none -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wformat -Wformat-security -Wvla -Wredundant-decls -Wdate-time -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wbidi-chars=any -Wundef -Wno-unused-parameter
Linker flags .......................... -O2 -g -fstack-reuse=none -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wl,-z,relro -Wl,-z,now -Wl,-z,separate-code -fPIE -pie

NOTE: The summary above may not exactly match the final applied build flags
      if any additional CMAKE_* or environment variables have been modified.
      To see the exact flags applied, build with the --verbose option.

Treat compiler warnings as errors ..... OFF
Use ccache for compiling .............. ON


-- Configuring done (42.1s)
-- Generating done (4.5s)
-- Build files have been written to: /home/brandon-odiwuor/bitcoin/bitcoin/build_dev_mode
[  0%] Generating bitcoin-build-info.h
[  0%] Built target generate_build_info
[  0%] Building CXX object src/CMakeFiles/bitcoin_node.dir/rpc/mempool.cpp.o
[  0%] Linking CXX static library ../lib/libbitcoin_node.a
[100%] Built target bitcoin_node
Built target bitcoin_cli
[100%] Built target bitcoin_consensus
[  0%] Generating bitcoin-build-info.h
[  0%] Built target generate_build_info
[100%] Built target bitcoin_wallet
[  0%] Generating bitcoin-build-info.h
[  0%] Built target generate_build_info
[  0%] Building CXX object src/CMakeFiles/bitcoin_common.dir/init/common.cpp.o
[  0%] Linking CXX static library ../lib/libbitcoin_common.a
[100%] Built target bitcoin_common
[  0%] Generating bitcoin-build-info.h
[  0%] Built target generate_build_info
[100%] Built target bitcoin_util
[100%] Built target bitcoin_crypto
Success! No unexpected dependencies were detected.

</details>

PR at 3c0e2f544ecc9097661baaac0ade1a4ea6ad6506

<details> <summary>Running `./contrib/devtools/check-deps.py` </summary>

brandon-odiwuor@brandon-odiwuor-ubuntu:~/bitcoin/bitcoin$ rm -rf build_dev_mode/
brandon-odiwuor@brandon-odiwuor-ubuntu:~/bitcoin/bitcoin$ cmake --preset dev-mode 
Preset CMake variables:

  BUILD_BENCH="ON"
  BUILD_CLI="ON"
  BUILD_DAEMON="ON"
  BUILD_FUZZ_BINARY="ON"
  BUILD_GUI="ON"
  BUILD_GUI_TESTS="ON"
  BUILD_KERNEL_LIB="ON"
  BUILD_SHARED_LIBS="ON"
  BUILD_TESTS="ON"
  BUILD_TX="ON"
  BUILD_UTIL="ON"
  BUILD_UTIL_CHAINSTATE="ON"
  BUILD_WALLET_TOOL="ON"
  ENABLE_EXTERNAL_SIGNER="ON"
  ENABLE_IPC="ON"
  ENABLE_WALLET="ON"
  WITH_QRENCODE="ON"
  WITH_USDT="ON"
  WITH_ZMQ="ON"

-- The CXX compiler identification is GNU 13.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting build type to "RelWithDebInfo" as none was specified
-- Performing Test CXX_SUPPORTS__WERROR
-- Performing Test CXX_SUPPORTS__WERROR - Success
-- Performing Test CXX_SUPPORTS__G3
-- Performing Test CXX_SUPPORTS__G3 - Success
-- Performing Test LINKER_SUPPORTS__G3
-- Performing Test LINKER_SUPPORTS__G3 - Success
-- Performing Test CXX_SUPPORTS__FTRAPV
-- Performing Test CXX_SUPPORTS__FTRAPV - Success
-- Performing Test LINKER_SUPPORTS__FTRAPV
-- Performing Test LINKER_SUPPORTS__FTRAPV - Success
-- Found SQLite3: /usr/include (found suitable version "3.45.1", minimum required is "3.7.17") 
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.8.1") 
-- Found ZeroMQ: /usr/lib/x86_64-linux-gnu (found suitable version "4.3.5", minimum required is "4.0.0") 
-- Performing Test HAVE_USDT_H
-- Performing Test HAVE_USDT_H - Success
-- Found USDT: /usr/include/x86_64-linux-gnu  
-- Found QRencode: /usr/lib/x86_64-linux-gnu/libqrencode.so (found version "4.1.1") 
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test HAVE_STDATOMIC
-- Performing Test HAVE_STDATOMIC - Success
-- Found WrapAtomic: TRUE  
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so   
-- Found WrapOpenGL: TRUE  
-- Could NOT find XKB (missing: XKB_LIBRARY XKB_INCLUDE_DIR) (Required is at least version "0.5.0")
-- Found WrapVulkanHeaders: /usr/include  
-- Found Qt: /usr/lib/x86_64-linux-gnu/cmake/Qt6 (found suitable version "6.4.2", minimum required is "6.2") 
-- Performing Test LINKER_SUPPORTS__WL___FATAL_WARNINGS
-- Performing Test LINKER_SUPPORTS__WL___FATAL_WARNINGS - Success
-- Performing Test FUZZ_BINARY_LINKS_WITHOUT_MAIN_FUNCTION
-- Performing Test FUZZ_BINARY_LINKS_WITHOUT_MAIN_FUNCTION - Failed
-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE
-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE - Success
-- Found Libevent: /usr/lib/x86_64-linux-gnu (found suitable version "2.1.12-stable", minimum required is "2.1.8") 
-- Performing Test HAVE_EVHTTP_CONNECTION_GET_PEER_CONST_CHAR
-- Performing Test HAVE_EVHTTP_CONNECTION_GET_PEER_CONST_CHAR - Failed
-- Looking for O_CLOEXEC
-- Looking for O_CLOEXEC - found
-- Looking for fdatasync
-- Looking for fdatasync - found
-- Looking for fork
-- Looking for fork - found
-- Looking for pipe2
-- Looking for pipe2 - found
-- Looking for setsid
-- Looking for setsid - found
-- Performing Test IFADDR_LINKS_WITHOUT_LIBSOCKET
-- Performing Test IFADDR_LINKS_WITHOUT_LIBSOCKET - Success
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC
-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC - Success
-- Looking for std::system
-- Looking for std::system - found
-- Looking for ::_wsystem
-- Looking for ::_wsystem - not found
-- Performing Test STRERROR_R_CHAR_P
-- Performing Test STRERROR_R_CHAR_P - Success
-- Looking for malloc_info
-- Looking for malloc_info - found
-- Performing Test HAVE_MALLOPT_ARENA_MAX
-- Performing Test HAVE_MALLOPT_ARENA_MAX - Success
-- Performing Test HAVE_POSIX_FALLOCATE
-- Performing Test HAVE_POSIX_FALLOCATE - Success
-- Performing Test HAVE_STRONG_GETAUXVAL
-- Performing Test HAVE_STRONG_GETAUXVAL - Success
-- Performing Test HAVE_SOCKADDR_UN
-- Performing Test HAVE_SOCKADDR_UN - Success
-- Performing Test HAVE_GETRANDOM
-- Performing Test HAVE_GETRANDOM - Success
-- Performing Test HAVE_GETENTROPY_RAND
-- Performing Test HAVE_GETENTROPY_RAND - Success
-- Performing Test HAVE_SYSCTL
-- Performing Test HAVE_SYSCTL - Failed
-- Performing Test HAVE_SYSCTL_ARND
-- Performing Test HAVE_SYSCTL_ARND - Failed
-- Performing Test HAVE_SSE41
-- Performing Test HAVE_SSE41 - Success
-- Performing Test HAVE_AVX2
-- Performing Test HAVE_AVX2 - Success
-- Performing Test HAVE_X86_SHANI
-- Performing Test HAVE_X86_SHANI - Success
-- Performing Test HAVE_ARM_SHANI
-- Performing Test HAVE_ARM_SHANI - Failed
-- Performing Test CXX_SUPPORTS__WALL
-- Performing Test CXX_SUPPORTS__WALL - Success
-- Performing Test CXX_SUPPORTS__WEXTRA
-- Performing Test CXX_SUPPORTS__WEXTRA - Success
-- Performing Test CXX_SUPPORTS__WGNU
-- Performing Test CXX_SUPPORTS__WGNU - Failed
-- Performing Test CXX_SUPPORTS__WCOVERED_SWITCH_DEFAULT
-- Performing Test CXX_SUPPORTS__WCOVERED_SWITCH_DEFAULT - Failed
-- Performing Test CXX_SUPPORTS__WFORMAT__WFORMAT_SECURITY
-- Performing Test CXX_SUPPORTS__WFORMAT__WFORMAT_SECURITY - Success
-- Performing Test CXX_SUPPORTS__WVLA
-- Performing Test CXX_SUPPORTS__WVLA - Success
-- Performing Test CXX_SUPPORTS__WSHADOW_FIELD
-- Performing Test CXX_SUPPORTS__WSHADOW_FIELD - Failed
-- Performing Test CXX_SUPPORTS__WTHREAD_SAFETY
-- Performing Test CXX_SUPPORTS__WTHREAD_SAFETY - Failed
-- Performing Test CXX_SUPPORTS__WTHREAD_SAFETY_POINTER
-- Performing Test CXX_SUPPORTS__WTHREAD_SAFETY_POINTER - Failed
-- Performing Test CXX_SUPPORTS__WLOOP_ANALYSIS
-- Performing Test CXX_SUPPORTS__WLOOP_ANALYSIS - Failed
-- Performing Test CXX_SUPPORTS__WREDUNDANT_DECLS
-- Performing Test CXX_SUPPORTS__WREDUNDANT_DECLS - Success
-- Performing Test CXX_SUPPORTS__WUNUSED_MEMBER_FUNCTION
-- Performing Test CXX_SUPPORTS__WUNUSED_MEMBER_FUNCTION - Failed
-- Performing Test CXX_SUPPORTS__WDATE_TIME
-- Performing Test CXX_SUPPORTS__WDATE_TIME - Success
-- Performing Test CXX_SUPPORTS__WCONDITIONAL_UNINITIALIZED
-- Performing Test CXX_SUPPORTS__WCONDITIONAL_UNINITIALIZED - Failed
-- Performing Test CXX_SUPPORTS__WDUPLICATED_BRANCHES
-- Performing Test CXX_SUPPORTS__WDUPLICATED_BRANCHES - Success
-- Performing Test CXX_SUPPORTS__WDUPLICATED_COND
-- Performing Test CXX_SUPPORTS__WDUPLICATED_COND - Success
-- Performing Test CXX_SUPPORTS__WLOGICAL_OP
-- Performing Test CXX_SUPPORTS__WLOGICAL_OP - Success
-- Performing Test CXX_SUPPORTS__WOVERLOADED_VIRTUAL
-- Performing Test CXX_SUPPORTS__WOVERLOADED_VIRTUAL - Success
-- Performing Test CXX_SUPPORTS__WSUGGEST_OVERRIDE
-- Performing Test CXX_SUPPORTS__WSUGGEST_OVERRIDE - Success
-- Performing Test CXX_SUPPORTS__WIMPLICIT_FALLTHROUGH
-- Performing Test CXX_SUPPORTS__WIMPLICIT_FALLTHROUGH - Success
-- Performing Test CXX_SUPPORTS__WUNREACHABLE_CODE
-- Performing Test CXX_SUPPORTS__WUNREACHABLE_CODE - Success
-- Performing Test CXX_SUPPORTS__WDOCUMENTATION
-- Performing Test CXX_SUPPORTS__WDOCUMENTATION - Failed
-- Performing Test CXX_SUPPORTS__WSELF_ASSIGN
-- Performing Test CXX_SUPPORTS__WSELF_ASSIGN - Failed
-- Performing Test CXX_SUPPORTS__WBIDI_CHARS_ANY
-- Performing Test CXX_SUPPORTS__WBIDI_CHARS_ANY - Success
-- Performing Test CXX_SUPPORTS__WUNDEF
-- Performing Test CXX_SUPPORTS__WUNDEF - Success
-- Performing Test CXX_SUPPORTS__WLEADING_WHITESPACE_SPACES
-- Performing Test CXX_SUPPORTS__WLEADING_WHITESPACE_SPACES - Failed
-- Performing Test CXX_SUPPORTS__WTRAILING_WHITESPACE_ANY
-- Performing Test CXX_SUPPORTS__WTRAILING_WHITESPACE_ANY - Failed
-- Performing Test CXX_SUPPORTS__WUNUSED_PARAMETER
-- Performing Test CXX_SUPPORTS__WUNUSED_PARAMETER - Success
-- Performing Test CXX_SUPPORTS__FNO_EXTENDED_IDENTIFIERS
-- Performing Test CXX_SUPPORTS__FNO_EXTENDED_IDENTIFIERS - Success
-- Performing Test CXX_SUPPORTS__FMACRO_PREFIX_MAP_A_B
-- Performing Test CXX_SUPPORTS__FMACRO_PREFIX_MAP_A_B - Success
-- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE
-- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE - Success
-- Performing Test LINKER_SUPPORTS__FSTACK_REUSE_NONE
-- Performing Test LINKER_SUPPORTS__FSTACK_REUSE_NONE - Success
-- Performing Test CXX_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_2d08
-- Performing Test CXX_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_2d08 - Success
-- Performing Test LINKER_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_2d08
-- Performing Test LINKER_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_2d08 - Success
-- Performing Test CXX_SUPPORTS__WSTACK_PROTECTOR
-- Performing Test CXX_SUPPORTS__WSTACK_PROTECTOR - Success
-- Performing Test CXX_SUPPORTS__FSTACK_PROTECTOR_ALL
-- Performing Test CXX_SUPPORTS__FSTACK_PROTECTOR_ALL - Success
-- Performing Test LINKER_SUPPORTS__FSTACK_PROTECTOR_ALL
-- Performing Test LINKER_SUPPORTS__FSTACK_PROTECTOR_ALL - Success
-- Performing Test CXX_SUPPORTS__FCF_PROTECTION_FULL
-- Performing Test CXX_SUPPORTS__FCF_PROTECTION_FULL - Success
-- Performing Test LINKER_SUPPORTS__FCF_PROTECTION_FULL
-- Performing Test LINKER_SUPPORTS__FCF_PROTECTION_FULL - Success
-- Performing Test CXX_SUPPORTS__FSTACK_CLASH_PROTECTION
-- Performing Test CXX_SUPPORTS__FSTACK_CLASH_PROTECTION - Success
-- Performing Test LINKER_SUPPORTS__FSTACK_CLASH_PROTECTION
-- Performing Test LINKER_SUPPORTS__FSTACK_CLASH_PROTECTION - Success
-- Performing Test LINKER_SUPPORTS__WL___ENABLE_RELOC_SECTION
-- Performing Test LINKER_SUPPORTS__WL___ENABLE_RELOC_SECTION - Failed
-- Performing Test LINKER_SUPPORTS__WL___DYNAMICBASE
-- Performing Test LINKER_SUPPORTS__WL___DYNAMICBASE - Failed
-- Performing Test LINKER_SUPPORTS__WL___NXCOMPAT
-- Performing Test LINKER_SUPPORTS__WL___NXCOMPAT - Failed
-- Performing Test LINKER_SUPPORTS__WL___HIGH_ENTROPY_VA
-- Performing Test LINKER_SUPPORTS__WL___HIGH_ENTROPY_VA - Failed
-- Performing Test LINKER_SUPPORTS__WL__Z_RELRO
-- Performing Test LINKER_SUPPORTS__WL__Z_RELRO - Success
-- Performing Test LINKER_SUPPORTS__WL__Z_NOW
-- Performing Test LINKER_SUPPORTS__WL__Z_NOW - Success
-- Performing Test LINKER_SUPPORTS__WL__Z_SEPARATE_CODE
-- Performing Test LINKER_SUPPORTS__WL__Z_SEPARATE_CODE - Success
-- Found Python3: /usr/bin/python3 (found suitable version "3.12.3", minimum required is "3.10") found components: Interpreter 
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE dot) 
-- Performing Test HAVE_BUILTIN_PREFETCH
-- Performing Test HAVE_BUILTIN_PREFETCH - Success
-- Performing Test HAVE_MM_PREFETCH
-- Performing Test HAVE_MM_PREFETCH - Success
-- Performing Test HAVE_SSE42
-- Performing Test HAVE_SSE42 - Success
-- Performing Test HAVE_ARM64_CRC32C
-- Performing Test HAVE_ARM64_CRC32C - Failed
-- Looking for F_FULLFSYNC
-- Looking for F_FULLFSYNC - not found
-- Performing Test HAVE_CLMUL
-- Performing Test HAVE_CLMUL - Success
-- Performing Test HAVE_PTHREAD_GETNAME_NP
-- Performing Test HAVE_PTHREAD_GETNAME_NP - Success
-- Performing Test HAVE_PTHREAD_THREADID_NP
-- Performing Test HAVE_PTHREAD_THREADID_NP - Failed
-- Performing Test HAVE_PTHREAD_GETTHREADID_NP
-- Performing Test HAVE_PTHREAD_GETTHREADID_NP - Failed
-- The C compiler identification is GNU 13.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done

Configuring secp256k1 subtree...
-- Performing Test HAVE_X86_64_ASM
-- Performing Test HAVE_X86_64_ASM - Success
-- Could NOT find Valgrind (missing: Valgrind_INCLUDE_DIR Valgrind_WORKS) 
-- Performing Test C_SUPPORTS__WALL
-- Performing Test C_SUPPORTS__WALL - Success
-- Performing Test C_SUPPORTS__PEDANTIC
-- Performing Test C_SUPPORTS__PEDANTIC - Success
-- Performing Test C_SUPPORTS__WCAST_ALIGN
-- Performing Test C_SUPPORTS__WCAST_ALIGN - Success
-- Performing Test C_SUPPORTS__WCAST_ALIGN_STRICT
-- Performing Test C_SUPPORTS__WCAST_ALIGN_STRICT - Success
-- Performing Test C_SUPPORTS__WCONDITIONAL_UNINITIALIZED
-- Performing Test C_SUPPORTS__WCONDITIONAL_UNINITIALIZED - Failed
-- Performing Test C_SUPPORTS__WEXTRA
-- Performing Test C_SUPPORTS__WEXTRA - Success
-- Performing Test C_SUPPORTS__WLEADING_WHITESPACE_SPACES
-- Performing Test C_SUPPORTS__WLEADING_WHITESPACE_SPACES - Failed
-- Performing Test C_SUPPORTS__WNESTED_EXTERNS
-- Performing Test C_SUPPORTS__WNESTED_EXTERNS - Success
-- Performing Test C_SUPPORTS__WNO_LONG_LONG
-- Performing Test C_SUPPORTS__WNO_LONG_LONG - Success
-- Performing Test C_SUPPORTS__WNO_OVERLENGTH_STRINGS
-- Performing Test C_SUPPORTS__WNO_OVERLENGTH_STRINGS - Success
-- Performing Test C_SUPPORTS__WNO_UNUSED_FUNCTION
-- Performing Test C_SUPPORTS__WNO_UNUSED_FUNCTION - Success
-- Performing Test C_SUPPORTS__WRESERVED_IDENTIFIER
-- Performing Test C_SUPPORTS__WRESERVED_IDENTIFIER - Failed
-- Performing Test C_SUPPORTS__WSHADOW
-- Performing Test C_SUPPORTS__WSHADOW - Success
-- Performing Test C_SUPPORTS__WSTRICT_PROTOTYPES
-- Performing Test C_SUPPORTS__WSTRICT_PROTOTYPES - Success
-- Performing Test C_SUPPORTS__WTRAILING_WHITESPACE_ANY
-- Performing Test C_SUPPORTS__WTRAILING_WHITESPACE_ANY - Failed
-- Performing Test C_SUPPORTS__WUNDEF
-- Performing Test C_SUPPORTS__WUNDEF - Success
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for sys/wait.h
-- Looking for sys/wait.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found


secp256k1 configure summary
===========================
Build artifacts:
  library type ........................ Static
Optional modules:
  ECDH ................................ OFF
  ECDSA pubkey recovery ............... ON
  extrakeys ........................... ON
  schnorrsig .......................... ON
  musig ............................... ON
  ElligatorSwift ...................... ON
Parameters:
  ecmult window size .................. 15
  ecmult gen table size ............... 86 KiB
Optional features:
  assembly ............................ x86_64
  external callbacks .................. OFF
Optional binaries:
  benchmark ........................... OFF
  noverify_tests ...................... ON
  tests ............................... ON
  exhaustive tests .................... ON
  ctime_tests ......................... OFF
  examples ............................ OFF

Cross compiling ....................... FALSE
API visibility attributes ............. OFF
Valgrind .............................. OFF
Preprocessor defined macros ........... ECMULT_WINDOW_SIZE=15 COMB_BLOCKS=43 COMB_TEETH=6 USE_ASM_X86_64=1
C compiler ............................ GNU 13.3.0, /usr/bin/cc
CFLAGS ................................ 
Compile options ....................... -Wall -pedantic -Wcast-align -Wcast-align=strict -Wextra -Wnested-externs -Wno-long-long -Wno-overlength-strings -Wno-unused-function -Wshadow -Wstrict-prototypes -Wundef
Build type:
 - CMAKE_BUILD_TYPE ................... RelWithDebInfo
 - CFLAGS ............................. -O2 -g 
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 

-- Performing Test CXX_SUPPORTS__WUNIQUE_OBJECT_DUPLICATION
-- Performing Test CXX_SUPPORTS__WUNIQUE_OBJECT_DUPLICATION - Failed


Configure summary
=================
Executables:
  bitcoin ............................. ON
  bitcoind ............................ ON
  bitcoin-node (multiprocess) ......... ON
  bitcoin-qt (GUI) .................... ON
  bitcoin-gui (GUI, multiprocess) ..... ON
  bitcoin-cli ......................... ON
  bitcoin-tx .......................... ON
  bitcoin-util ........................ ON
  bitcoin-wallet ...................... ON
  bitcoin-chainstate (experimental) ... ON
  libbitcoinkernel (experimental) ..... ON
  kernel-test (experimental) .......... ON
Optional features:
  wallet support ...................... ON
  external signer ..................... ON
  ZeroMQ .............................. ON
  IPC ................................. ON
  Embedded ASMap ...................... ON
  USDT tracing ........................ ON
  QR code (GUI) ....................... ON
  DBus (GUI) .......................... ON
Tests:
  test_bitcoin ........................ ON
  test_bitcoin-qt ..................... ON
  bench_bitcoin ....................... ON
  fuzz binary ......................... ON

Cross compiling ....................... FALSE
C++ compiler .......................... GNU 13.3.0, /usr/bin/c++
CMAKE_BUILD_TYPE ...................... RelWithDebInfo
Preprocessor defined macros ........... 
C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fno-extended-identifiers -fmacro-prefix-map=/home/brandon-odiwuor/bitcoin/bitcoin/src=. -fstack-reuse=none -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wall -Wextra -Wformat -Wformat-security -Wvla -Wredundant-decls -Wdate-time -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wbidi-chars=any -Wundef -Wno-unused-parameter
Linker flags .......................... -O2 -g -fstack-reuse=none -fstack-protector-all -fcf-protection=full -fstack-clash-protection -Wl,-z,relro -Wl,-z,now -Wl,-z,separate-code -fPIE -pie

NOTE: The summary above may not exactly match the final applied build flags
      if any additional CMAKE_* or environment variables have been modified.
      To see the exact flags applied, build with the --verbose option.

Treat compiler warnings as errors ..... OFF
Use ccache for compiling .............. ON


-- Configuring done (30.8s)
-- Generating done (0.5s)
-- Build files have been written to: /home/brandon-odiwuor/bitcoin/bitcoin/build_dev_mode
brandon-odiwuor@brandon-odiwuor-ubuntu:~/bitcoin/bitcoin$ ./contrib/devtools/check-deps.py build_dev_mode/
Warning: targets not buildable: bitcoin_kernel
Success! No unexpected dependencies detected.

sedited approved

sedited commented at 8:46 PM on May 1, 2026: contributor

Re-ACK 3c0e2f544ecc9097661baaac0ade1a4ea6ad6506

DrahtBot requested review from BrandonOdiwuor on May 1, 2026

DrahtBot requested review from janb84 on May 1, 2026